1898363 - New profiles missing install source

Status: RESOLVED FIXED

(Firefox for Android :: Experimentation and Telemetry, task)

Description

[Richard Baffour Awuah]

There some new profiles that we have attributed to marketing campaigns but we do not have an installation source for them in telemetry. We get the installation source when the the profile send metric pings ping to telemetry. Since all new profiles that get attributed to marketing campaign send first session ping, we wanted to get a probe for the installation source added to the first session pings.

This will help marketing measurement become more precise.

Comment 1

[Roger Yang [:royang]]

I'm assuming the ask is to add the install source to the first session

Comment 2

[twhite]

Attachment: Bug 1898363 - Add the installation source to the first session pings

Comment 3

[Richard Baffour Awuah]

(In reply to Roger Yang [:royang] from comment #1)

I'm assuming the ask is to add the install source to the first session

Yes we want to add it to the first session ping, we have a hypothesis that the instances in which it does not exist for a given client is largely because the client never sent any metrics ping. Both all of the clients we were examining reported a first session ping.

Comment 4

[twhite]

Attachment: Data-review request

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dbe5fd9ed402
Add the installation source to the first session pings r=android-reviewers,Roger

Comment 6

[Serban Stanca [:SerbanS]]

Backed out for causing lint failures.

• Backout link
• Push with failures
• Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a7cd495bf2a
Add the installation source to the first session pings r=android-reviewers,Roger

Comment 8

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/7a7cd495bf2a

Comment 9

[twhite]

Comment on attachment 9406071 [details]
Bug 1898363 - Add the installation source to the first session pings

Beta/Release Uplift Approval Request

• User impact if declined: None
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change to add addational telemetry data. Unit tests. Has been soaked in Nightly for a week already
• String changes made/needed:
• Is Android affected?: No

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9406071 [details]
Bug 1898363 - Add the installation source to the first session pings

Approved for 128.0b5.

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/20b40e92472a

Comment 12

[Pascal Chevrel:pascalc]

Comment on attachment 9406071 [details]
Bug 1898363 - Add the installation source to the first session pings

Approved for 127.0.2, thanks.

Comment 13

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/bfa5f246a4bd

Comment 14

[Richard Baffour Awuah]

Hi, the fix after looking at the data is not what we wanted. We want the ping added to the first session ping but what you have done is add "first_session.install_source" to metrics ping. This means if a client does not report a metric ping, we will not be able to see the install source which is reason why wanted this to be part of the first session ping in the first place.

The correct solution will add install source to https://dictionary.telemetry.mozilla.org/apps/fenix/pings/first-session

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Fenix::Experimentation and Telemetry' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 16

[twhite]

Fix applied in https://bugzilla.mozilla.org/show_bug.cgi?id=1908383