Closed Bug 1898467 Opened 9 months ago Closed 3 months ago

Implement about:credits on seamonkey-project.org website

Categories

(SeaMonkey :: Website, enhancement)

Product:
SeaMonkey
Component:
Website
Version:
Production
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mac198442, Assigned: mac198442)

References

Details

(Whiteboard: SM2.53.19)

Attachments

(4 files, 8 obsolete files)

1898467-about-credits.patch
5.68 KB, patch
frg
: review+
Details | Diff | Splinter Review
1898467-about-credits-2.patch
1.02 KB, patch
frg
: review+
Details | Diff | Splinter Review
1898467-3-followup.patch
3.36 KB, patch
frg
: review+
Details | Diff | Splinter Review
1898467-4-followup-formatting-add-myckel.patch
1.00 KB, patch
frg
: review+
Details | Diff | Splinter Review

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0

Attached patch 1898467-about-credits.patch (obsolete) — — Splinter Review

This patch implements the website part of SeaMonkey about:credits.

Attachment #9403471 - Flags: review?(frgrahl)
Attached patch 1898467-about-credits.patch (obsolete) — — Splinter Review

add seamonkey header image to the FAQ page and fix stray </div>

Attachment #9403471 - Attachment is obsolete: true
Attachment #9403471 - Flags: review?(frgrahl)
Attachment #9403490 - Flags: review?(iannbugzilla)
Attached patch 1898467-about-credits.patch (obsolete) — — Splinter Review

Fix left margin issue under SeaMonkey

Attachment #9403490 - Attachment is obsolete: true
Attachment #9403490 - Flags: review?(iannbugzilla)
Attachment #9403509 - Flags: review?(iannbugzilla)

If you are not running a seamonkey nightly build, or are using a browser other than seamonkey, you can see how this should work when landed by going to https://www.wg9s.com/credits/

Attached patch 1898467-about-credits.patch (obsolete) — — Splinter Review
Attachment #9403509 - Attachment is obsolete: true
Attachment #9403509 - Flags: review?(iannbugzilla)
Attachment #9403727 - Flags: review?(iannbugzilla)

Comment on attachment 9403727 [details] [diff] [review]
1898467-about-credits.patch

Added Tobin and tomman to credits.txt.

Assignee: nobody → mac198442
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Whiteboard: SM2.53.19
Version: SeaMonkey 2.53 Branch → Production
Comment on attachment 9403727 [details] [diff] [review] 1898467-about-credits.patch Review of attachment 9403727 [details] [diff] [review]: ----------------------------------------------------------------- ::: src/credits/credits_faq.html @@ +1,2 @@ > +<!DOCTYPE html> > +<html class="linux js x64 is-modern-browser loaded" dir="ltr" data-country-code="US" data-latest-firefox="125.0.1" data-esr-versions="115.10.0" data-gtm-container-id="GTM-MW3R8V" data-stub-attribution-rate="1.0" data-sentry-dsn="https://c3ab8514873549d5b3785ebc7fb83c80@o1069899.ingest.sentry.io/6260331" lang="en"><head> This just needs to be <html lang="en"> @@ +16,5 @@ > +contributed, or who they work for.</p> > + > +<h2>Who is eligible?</h2> > + > +<p>The agreed criteria is people who have "made a significant investment of time and effort into SeaMonkey".</p> Wrap this line please to 80 characters. @@ +29,5 @@ > +:-)</p> > + > +<h2>How do I get added?</h2> > + > +<p>See the bottom of <a href="https://www.wg9s.com/credits/">about:credits</a>, and click the link there. Remember to include a justification.</p> Is this line correct? Needs wrapping to 80 characters. @@ +51,5 @@ > +<h2>When will I get added, and how do I know?</h2> > + > +<p>You will receive an email when your name is added. > + If your application does not meet the criteria mentioned above, your > +name will not be added. You will recieve an email about what was deemed insufficient and asked to re-apply once you have a stronger justification and further evidence.</p> This line needs wrapping to 80 characters. ::: src/credits/index.html @@ +11,5 @@ > +<body id="aboutPageContainer" class="aboutPageWideContainer"> > + > +<h1>SeaMonkey Contributors</h1> > + > +<p>We would like to thank our contributors, whose efforts have made this software what it is today.</p> This line needs wrapping to 80 characters @@ +17,5 @@ > +<!--#include virtual="credits.txt" --> > +</p> > +<hr> > +<!--#config timefmt="%B %d, %Y" --> > +This is a list of people who have made a significant investment of time and effort into SeaMonkey activities. Any such contributors who wish to be added to the list should <a href="request.html">click here</a>. There is a <a href=credits_faq.html>FAQ</a> about this process. The list was last updated <!--#flastmod file="credits.txt" -->. These lines need wrapping to 80 characters @@ +19,5 @@ > +<hr> > +<!--#config timefmt="%B %d, %Y" --> > +This is a list of people who have made a significant investment of time and effort into SeaMonkey activities. Any such contributors who wish to be added to the list should <a href="request.html">click here</a>. There is a <a href=credits_faq.html>FAQ</a> about this process. The list was last updated <!--#flastmod file="credits.txt" -->. > +<hr> > +<a href=https://www.mozilla.org/credits/>Additionally, the Mozilla Foundation credits these others with contributing to the gecko backend that is used by SeaMonkey</a> This line needs wrapping to 80 characters ::: src/credits/request.html @@ +8,5 @@ > +<h1><a href="/" title="Go to seamonkey-project.org" accesskey="1"><img > + src="/images/template/header-logo.png" height="38" width="260" alt="SeaMonkey Project"></a></h1> > +<h3>SeaMonkey Contributor Request </h3> > +<p> > +To request inclusion in Seamonkey Credits, send an email to seamonkey-council@mozilla.org with a subject of "SeaMonkey credits request".</p> This line needs wrapping to 80 characters
Attachment #9403727 - Flags: review?(iannbugzilla) → review-
Attached patch 1898467-about-credits.patch (obsolete) — — Splinter Review

Address review comments and add .en. to the filenames.

Attachment #9403727 - Attachment is obsolete: true
Attachment #9404267 - Flags: review?(iannbugzilla)
Attached patch 1898467-about-credits.patch (obsolete) — — Splinter Review

change credits.en.txt back to credits.txt

Attachment #9404267 - Attachment is obsolete: true
Attachment #9404267 - Flags: review?(iannbugzilla)
Attachment #9404269 - Flags: review?(iannbugzilla)
Comment on attachment 9404269 [details] [diff] [review] 1898467-about-credits.patch Review of attachment 9404269 [details] [diff] [review]: ----------------------------------------------------------------- Also need to work out how the credits section is going to link into the overall site. A sub page of About? lib/sitemap.xml will need updating to link to it. ::: src/credits/credits_faq.en.html @@ +31,5 @@ > + > +<h2>How do I get added?</h2> > + > +<p>See the bottom of <a href="https://www.wg9s.com/credits/">about:credits</a>, > +and click the link there. Remember to include a justification.</p> Shouldn't this match the information in request.en.html file? ::: src/credits/index.en.html @@ +14,5 @@ > + > +<p>We would like to thank our contributors, whose efforts have made this > +software what it is today.</p> > +<p> > +<!--#include virtual="credits.txt" --> I don't think this works at ttree is used to process the files: https://template-toolkit.org/docs/tools/ttree.html Look at pages like src/news.en.html and how it uses src/news.en.xml to build entries @@ +24,5 @@ > +the list should <a href="request">click here</a>. There is a > +<a href=credits_faq>FAQ</a> about this process. The list was last > +updated <!--#flastmod file="credits.txt" -->. > +<hr> > +<a href=https://www.mozilla.org/credits/>Additionally, the Mozilla Foundation credits these others with contributing to the gecko backend that is used by SeaMonkey</a> line is over 80 characters
Attachment #9404269 - Flags: review?(iannbugzilla) → review-
Attached patch 1898467-about-credits.patch (obsolete) — — Splinter Review

Address review comments

Attachment #9404269 - Attachment is obsolete: true
Attachment #9405953 - Flags: review?(iannbugzilla)
Blocks: 1902935

Add robots.txt change

Attachment #9411862 - Flags: review?(iannbugzilla)
Attachment #9405953 - Attachment is obsolete: true
Attachment #9405953 - Flags: review?(iannbugzilla)

This is the change I made for insert the txt file.

Attachment #9433480 - Attachment is obsolete: true
Attachment #9433492 - Flags: review?(frgrahl)
Attachment #9433797 - Flags: review?(frgrahl)

Comment on attachment 9433492 [details] [diff] [review]
1898467-3-followup.patch

lgtm r+

Attachment #9433492 - Flags: review?(frgrahl) → review+

Comment on attachment 9433797 [details] [diff] [review]
1898467-4-followup-formatting-add-myckel.patch

lgtm r+

Attachment #9433797 - Flags: review?(frgrahl) → review+

Comment on attachment 9411862 [details] [diff] [review]
1898467-about-credits.patch

r+ from IanN over irc

Attachment #9411862 - Flags: review?(iannbugzilla) → review+

Comment on attachment 9433481 [details] [diff] [review]
1898467-about-credits-2.patch

r+ from IanN himself implied

Attachment #9433481 - Flags: review+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: