1898501 - Enable playback of MP4 videos with YUV444 format

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

MP4/H264 videos with YUV444 format is supported on Linux and works on other browsers (Chrome/Chromium etc.). Firefox is the only one broken. The video format is already used (for instance Bug 1898379 attachment with reproducer) so we should enable it too to make Firefox on the same level as other browsers.

See https://bugzilla.mozilla.org/show_bug.cgi?id=1291742#c40 and bellow for references.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1898501 [Linux] Allow to play H264/YUV444 format on Linux r?alwu

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Should it be mentioned in the release notes?

Comment 3

[Darkspirit]

Does OpenH264 support YUV444 now or would this change be only for ffmpeg?

Comment 4

[Martin Stránský [:stransky] (ni? me)]

(In reply to Darkspirit from comment #3)

Does OpenH264 support YUV444 now or would this change be only for ffmpeg?

AFAIK if OpenH264 doesn't support YUV444 the result will be the same as it's now - a message about broken video format.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:stransky, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 6

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1898501 [Linux] Add support of YUVJ444P format r?alwu

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b99f7fddaa5
[Linux] Allow to play H264/YUV444 format on Linux r=alwu

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/393040878a1f
[Linux] Add support of YUVJ444P format r=alwu

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Alwu, which test will be suitable for it?

Reftest or something else which just loads the clip? I generated YUV444P (and YUVJ444P) clips by gen_combos.py at dom/media/test/reftest and added the files to dom/media/test/reftest/color_quads/reftest.list, is that correct approach?

Thanks.

Comment 10

[Cristian Tuns]

Backed out for causing reftest and mochitest failures(720p.png.bt709.bt709.tv.gbrp.h264.mp4 , test_bug1354633_media_error.html)

• Backout link
• Push with failures
  Push with mochitest failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/resistfingerprinting/test/mochitest/test_bug1354633_media_error.html | Test timed out. -
• Failure Log reftest
• Failure line reftest: REFTEST TEST-UNEXPECTED-FAIL | dom/media/test/reftest/color_quads/720p.png.bt709.bt709.tv.gbrp.h264.mp4 == dom/media/test/reftest/color_quads/reftest_video.html?src=timeout | image comparison, max difference: 255, number of differing pixels: 273095
  REFTEST TEST-UNEXPECTED-FAIL | dom/media/test/reftest/color_quads/720p.png.bt709.bt709.pc.gbrp.h264.mp4 == dom/media/test/reftest/color_quads/720p.png.bt709.bt709.tv.gbrp.h264.mp4 | image comparison, max difference: 119, number of differing pixels: 25451

Comment 11

[Alastor Wu [:alwu]]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #9)

Alwu, which test will be suitable for it?

Reftest or something else which just loads the clip? I generated YUV444P (and YUVJ444P) clips by gen_combos.py at dom/media/test/reftest and added the files to dom/media/test/reftest/color_quads/reftest.list, is that correct approach?

Thanks.

Reftest sounds right to me. I think reftest_video.html can be used in testing YUV444P.

Comment 12

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/393040878a1f

Comment 13

[Martin Stránský [:stransky] (ni? me)]

Yes, looks like there are two issues here.

• reftest - we expected decode timeout but decode works on Linux now. We may disable that timeout test now and add correct decode test for Linux.
• Mochitest - browser/components/resistfingerprinting/test/mochitest/test_bug1354633_media_error.html - there's a YUV444P video clip used to throw "decode error" message and test exposed info. As long as we decode it now the test is broken. We may need to come with different weird video format to test decode error :)

Comment 14

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1898501 [Linux] Disable reftest video decode timeout on Linux and Android as we do decode now r?alwu

Depends on D211370

Comment 15

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1898501 Change decode_error.mp4 video format from H264/yuv444p to VP9/gbrp12le r?alwu

As H264/yuv444p is supported now on Linux we need a different video format which fails to decode.
VP9/gbrp12le seems to be exotic enough.

Depends on D217089

Comment 16

[Martin Stránský [:stransky] (ni? me)]

Try looks green: https://treeherder.mozilla.org/jobs?repo=try&revision=02d0f5f279c3ad2e47334b1d390547dca8385213

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49a31919e147
[Linux] Allow to play H264/YUV444 format on Linux r=alwu
https://hg.mozilla.org/integration/autoland/rev/5017e396b69b
[Linux] Disable reftest video decode timeout on Linux as we do decode now r=alwu
https://hg.mozilla.org/integration/autoland/rev/acc5c64134ee
Change decode_error.mp4 video format from H264/yuv444p to VP9/gbrp12le r=alwu

Comment 18

[Serban Stanca [:SerbanS]]

Backed out for causing reftests failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: REFTEST TEST-UNEXPECTED-FAIL | dom/media/test/reftest/color_quads/720p.png.bt709.bt709.tv.gbrp.h264.mp4 == dom/media/test/reftest/color_quads/reftest_video.html?src=timeout | image comparison, max difference: 255, number of differing pixels: 359855

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77ee1a53de8b
[Linux] Allow to play H264/YUV444 format on Linux r=alwu
https://hg.mozilla.org/integration/autoland/rev/c0b6bac8dec2
[Linux] Disable reftest video decode timeout on Linux and Android as we do decode now r=alwu
https://hg.mozilla.org/integration/autoland/rev/b94ec5ba05c9
Change decode_error.mp4 video format from H264/yuv444p to VP9/gbrp12le r=alwu

Comment 20

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/77ee1a53de8b
https://hg.mozilla.org/mozilla-central/rev/c0b6bac8dec2
https://hg.mozilla.org/mozilla-central/rev/b94ec5ba05c9