1898515 - Disable `performance.clone.deserialize` metrics in Android

Status: RESOLVED FIXED

(Core :: XPConnect, task, P1)

Description

[Chris H-C :chutten]

These metrics are high-volume, leading to some negative performance impacts in Firefox for Android.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Here's a profile of Firefox Nightly that shows us nearly saturating an entire core doing telemetry db serialization while scrolling news.ycombinator.com

https://share.firefox.dev/4arKYKE

Comment 2

[Chris H-C :chutten]

Attachment: Bug 1898515 - Disable clone deserialize instrumentation on Android r?sfink!,jrmuizel!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98be0e0b6e10
Disable clone deserialize instrumentation on Android r=jrmuizel

Comment 4

[Chris H-C :chutten]

Attachment: Bug 1898515 - Disable clone deserialize instrumentation on Android r?sfink!,jrmuizel!

Original Revision: https://phabricator.services.mozilla.com/D211382

Comment 5

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Negative perf impact on startup and common actions like scrolling webpages
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Medium
• Explanation of risk level: Low because it's solely omitting instrumentation code only on Android, Medium because it's not covered by tests
• String changes made/needed: None
• Is Android affected?: yes

Comment 6

[Chris H-C :chutten]

Attachment: Bug 1898515 - Disable clone deserialize instrumentation on Android r?sfink!,jrmuizel!

Original Revision: https://phabricator.services.mozilla.com/D211382

Comment 7

[Phabricator Automation]

release Uplift Approval Request

• User impact if declined: Negative perf impact on startup and common actions like scrolling webpages
• Code covered by automated testing: no
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: Medium
• Explanation of risk level: Low because it's solely omitting instrumentation code only on Android, Medium because it's not covered by tests
• String changes made/needed: N/A
• Is Android affected?: yes

Comment 8

[Jeff Muizelaar [:jrmuizel]]

For the record, the structured clone during scroll appears to be coming from receiving "GeckoView:ScrollChanged" in the parent.

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/98be0e0b6e10

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/8addc851ac48

Comment 11

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/b3d196e94209