1898552 - Add support for Nimbus' recorded targeting context

Status: RESOLVED FIXED

(Fenix :: Experimentation and Telemetry, enhancement)

Description

[Charlie Humphreys [:charlie] [:jeddai]]

• Define recorded_nimbus_context object metric
• Define and use RecordedNimbusContext Kotlin object and pass it through to Nimbus

See EXP-4446 for more details.

Comment 1

[Charlie Humphreys [:charlie] [:jeddai]]

Attachment: Bug 1898552: Define and use Nimbus RecordedContext object r?lina,barret,janerik

Comment 2

[Charlie Humphreys [:charlie] [:jeddai]]

Attachment: data review request

Comment 3

[Travis Long [:travis_]]

Comment on attachment 9406713 [details]
data review request

Data Review

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, through the metrics.yaml file and the Glean Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, through the data preferences in the application settings.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Permanent collection to be monitored by [e-mail] & [e-mail]

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2

5. Is the data collection request for default-on or default-off?

Default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does the data collection use a third-party collection tool?

No

Result

data-review+

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbc9786ba381
Define and use Nimbus RecordedContext object r=lina,android-reviewers,barret,Roger

Comment 5

[Serban Stanca [:SerbanS]]

Backed out for causing toolchain failures in BrowserFragment.kt.

• Backout link
• Push with failures
• Failure Log
• Failure line: file:///builds/worker/workspace/build/src/mobile/android/fenix/app/src/main/java/org/mozilla/fenix/browser/BrowserFragment.kt:344:40: error: Unresolved reference: cancelTapped

Comment 6

[Travis Long [:travis_]]

I think I know what happened here to cause this to be backed out: you inserted your event in the metrics.yaml in a place that caused cancel_tapped to change its metric category, and thus its generated metric name. This lead to the cancelTapped object not being found in the calling code.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/757bbd386da2
Define and use Nimbus RecordedContext object r=lina,android-reviewers,barret,Roger,TravisLong

Comment 8

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/757bbd386da2