Closed Bug 1898556 Opened 1 month ago Closed 1 month ago

Remove the use of eslint-plugin-file-header - covered by the license linter

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Tracking

(firefox128 fixed)

RESOLVED FIXED
128 Branch
Tracking Status
firefox128 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

Attachments

(2 files)

eslint-plugin-file-header is used by the devtools' debugger code to ensure that all of its files have a license header. Whilst it still works it may need update for ESLint v9. However, given that the functionality is the same as that provided by our own license linter, I think we should just use our own one and remove the additional plugin.

The license linter doesn't currently lint tests (bug 1713577), which would mean that we'd loose coverage for those, but it is a small part of the tree. I did look at enabling coverage for those, but it isn't trivial as it would mean listing a lot of directories to exclude from the linter.

The updates are general updates, though some of them include ESLint v9 compatibility changes

Attachment #9403572 - Attachment description: WIP: Bug 1898556 - Remove eslint-plugin-file-header, update various node modules. → Bug 1898556 - Remove eslint-plugin-file-header, update various node modules. r?#frontend-codestyle-reviewers!
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2bc37fe6a5aa
Remove use of eslint-plugin-file-header from devtools. r=devtools-reviewers,frontend-codestyle-reviewers,nchevobbe,Gijs
https://hg.mozilla.org/integration/autoland/rev/32185a831195
Remove eslint-plugin-file-header, update various node modules. r=frontend-codestyle-reviewers,Gijs
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: