1898565 - Add missing quotes in error message for invalid header value in network.continueRequest

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect, P2)

Description

[Julian Descottes [:jdescottes]]

I introduced slightly inconsistent error messages between invalid header names and values:

`Expected "header" name to be a valid HTTP token, got ${deserializedHeader[0]}`

`Expected header value to be a valid header value, got ${deserializedHeader[1]}`

We are missing " around header in the second message, it would be better to fix it since Puppeteer will use the error message in their implemenation to detect header issues.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1898565 - [bidi] Add quotes in message for invalid header value in network.continueRequest

Depends on D210518

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e388b7f6f91
[bidi] Add quotes in message for invalid header value in network.continueRequest r=webdriver-reviewers,jgraham

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2e388b7f6f91

Comment 4

[Atila Butkovits]

Backed out for causing high frequency failures at url_patterns.py

Backout link: https://hg.mozilla.org/integration/autoland/rev/c5f0d71de69cf598d009f69c9ddf56fb6058bc9e

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=aNUnl0SdSJSaPYpgdA1p9g.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=windows%2C11%2Cx64%2C22h2%2Cwebrender%2Copt%2Cweb%2Cplatform%2Ctests%2Ctest-windows11-64-2009-qr%2Fopt-web-platform-tests-wdspec%2Cwd4&revision=2e388b7f6f914a31e5dbf521525f390163191bb4

Failure log: https://treeherder.mozilla.org/logviewer?job_id=459502969&repo=autoland&lineNumber=128070

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46472 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03d67eccec8f
[bidi] Add quotes in message for invalid header value in network.continueRequest r=webdriver-reviewers,jgraham

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/03d67eccec8f