1898572 - `if (byteLength > LZ4MaxSize)` warning

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Yury Delendik (:yury)]

On 32-bit systems, build complaints:

 3:41.51 /home/yury/Work/mozilla-unified/js/src/shell/js.cpp:9049:18: warning: result of comparison 'size_t' (aka 'unsigned int') > 4294967295 is always false [-Wtautological-type-limit-compare]
 3:41.51  9049 |   if (byteLength > LZ4MaxSize) {
 3:41.51       |       ~~~~~~~~~~ ^ ~~~~~~~~~~
 3:47.44 memory/build/test

which makes sense that on 32-bit ArrayBufferObject will never allocate array buffer more than LZ4MaxSize = UINT32_MAX.

It nice to hide this warning during the build.

Comment 1

[Ryan Hunt [:rhunt]]

Attachment: Bug 1898572 - wasm: Fix warning. r?yury

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb40aa8815f3
wasm: Fix warning. r=yury

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bb40aa8815f3