1898604 - [toolbar redesign] With tab strip enabled in tablet toolbar is not hiding correctly

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect)

Description

[Roger Yang [:royang]]

Attachment: Screen_recording_20240523_154558.webm

With tabs strip enabled, scroll smoothly in sites like Wikipedia.
The expected behaviour is that the toolbar and tab strip will hide while scrolling up. However, when toolbar redesign is enabled the hiding behaviour is incorrect.

Comment 1

[Mike a [:mavduevskiy]]

Attachment: Bug 1898604 - Fix tabstrip scrolling for tablets

The problem was caused casting in EngineViewClippingBehavior. It assumed that ToolbarContainerView could be only at the bottom, but Tabstrip added one on top as well. Removed casting from onDependentViewChanged, now it calculates the dependant position with a simple equasion.

Comment 2

[Mike a [:mavduevskiy]]

Attachment: Bug 1898604 - Refactor EngineViewClippingBehaviorTest tests to be more concise

Tests became quite verbose, refactored repeated object creation into class parameters and helper functions.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87287ee27746
Fix tabstrip scrolling for tablets r=android-reviewers,Roger
https://hg.mozilla.org/integration/autoland/rev/9587f4babf2e
Refactor EngineViewClippingBehaviorTest tests to be more concise r=android-reviewers,gl,harrisono

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/87287ee27746
https://hg.mozilla.org/mozilla-central/rev/9587f4babf2e