1898625 - Apply scroll snapping during scene building prior to external scroll offset

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task)

Comment 1

[Glenn Watson [:gw]]

This is the next step towards support for fractional scroll offsets.

Comment 2

[Glenn Watson [:gw]]

Attachment: Bug 1898625 - Pt 1 - Snap clip display items prior to applying external scroll offset

Comment 3

[Glenn Watson [:gw]]

Attachment: Bug 1898625 - Pt 2 - Snap hit test items prior to applying external scroll offset

Comment 4

[Glenn Watson [:gw]]

Attachment: Bug 1898625 - Pt 3 - Snap iframe rects prior to applying external scroll offset

Comment 5

[Glenn Watson [:gw]]

Attachment: Bug 1898625 - Pt 4 - remove snapping from box-shadow rect after spread + offset applied

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8c42063aedd
Pt 1 - Snap clip display items prior to applying external scroll offset r=gfx-reviewers,aosmond

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a8c42063aedd

Comment 8

[Alessandro Castellani [:aleca]]

Attachment: Recording 2024-05-28 170832.mp4

Hi, this first patch created a regression in Thunderbird folder pane.
When scrolling the hover effects or selection effects seem to remain "sticky" in their original position.
Here's a video to how the issue.

Backing out this patch fixes the issue.
Do we need to do anything in Thunderbird to follow this changes?

Comment 9

[Glenn Watson [:gw]]

I think I can spot a typo in that patch that could explain what's happening there - I'll ask for it to be backed out for now. Then, I'll fix it up, re-land it and we can see if it fixes the problem in TB. It's surprising that this doesn't get caught by any Fx tests if it's what I think it is...

Comment 10

[Narcis Beleuzu [:NarcisB]]

Backed out for causing a regression in Thunderbird.
Backout link: https://hg.mozilla.org/mozilla-central/rev/198b8c4a9b506b8bb15c4bc93dba876c4bdb1289

Comment 11

[Andrew McCreight [:mccr8]]

This (or something) also completely broke graphics for me on Nightly Firefox. Like a page looks fine (say, Reddit) but then if you scroll down the image stays behind. Also images aren't loading on Discord properly. (I'm on MacOS ARM64)

Comment 12

[Alessandro Castellani [:aleca]]

Thank you so much for the quick backout.
I'm more than happy to pull the revised patch and build Thunderbird locally to test it if you want.
Feel free to ping me on the phab revision if you need.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

(In reply to Glenn Watson [:gw] from comment #9)

It's surprising that this doesn't get caught by any Fx tests if it's what I think it is...

Extremely! I hope that's something we intend to resolve as well :-)

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/47914d344795
Pt 1 - Snap clip display items prior to applying external scroll offset r=gfx-reviewers,aosmond

Comment 15

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/47914d344795

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afea607f342b
Pt 2 - Snap hit test items prior to applying external scroll offset r=gfx-reviewers,aosmond

Comment 17

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/afea607f342b

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb6c9affbe78
Pt 3 - Snap iframe rects prior to applying external scroll offset r=gfx-reviewers,aosmond

Comment 19

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/eb6c9affbe78

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7c479e0c45e
Pt 4 - remove snapping from box-shadow rect after spread + offset applied r=gfx-reviewers,aosmond

Comment 21

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a7c479e0c45e