macOS non-debug artifact builds have incorrect update `nightly` channel
Categories
(Toolkit :: Application Update, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr115 | --- | unaffected |
| firefox126 | --- | unaffected |
| firefox127 | --- | wontfix |
| firefox128 | --- | fixed |
People
(Reporter: nalexander, Assigned: nalexander)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fidedi-ope])
Attachments
(1 external file)
Looks like I didn't get Bug 1885985 quite right. A debug build looks as expected:
$ cat mozconfig-browser-artifact
mk_add_options AUTOCLOBBER=1
ac_add_options --enable-application=browser
ac_add_options --enable-debug
ac_add_options --enable-artifact-builds
mk_add_options MOZ_OBJDIR="../objdirs/objdir-browser-artifact"
$ find ../objdirs/objdir-browser-artifact -iname 'ChannelPrefs' -type file | xargs shasum
3f8d12a8b3f73325b354778714cddf7e296f665b ../objdirs/objdir-browser-artifact/dist/update_framework_artifacts/ChannelPrefs-localbuild.framework/ChannelPrefs
3f8d12a8b3f73325b354778714cddf7e296f665b ../objdirs/objdir-browser-artifact/dist/bin/ChannelPrefs.framework/ChannelPrefs
3f8d12a8b3f73325b354778714cddf7e296f665b ../objdirs/objdir-browser-artifact/dist/NightlyDebug.app/Contents/Frameworks/ChannelPrefs.framework/ChannelPrefs
$ find ../objdirs/objdir-browser-artifact -iname 'UpdateSettings' -type file | xargs shasum
e6e90f805e45e63dbde04e9da40581462f5b44a1 ../objdirs/objdir-browser-artifact/_tests/xpcshell/toolkit/mozapps/update/tests/data/updater.app/Contents/Frameworks/UpdateSettings.framework/UpdateSettings
e6e90f805e45e63dbde04e9da40581462f5b44a1 ../objdirs/objdir-browser-artifact/_tests/testing/mochitest/browser/toolkit/mozapps/update/tests/browser/updater.app/Contents/Frameworks/UpdateSettings.framework/UpdateSettings
27f27ea9198d682238229df87256592211d62e5f ../objdirs/objdir-browser-artifact/dist/update_framework_artifacts/UpdateSettings-localbuild.framework/UpdateSettings
27f27ea9198d682238229df87256592211d62e5f ../objdirs/objdir-browser-artifact/dist/bin/updater.app/Contents/Frameworks/UpdateSettings.framework/UpdateSettings
27f27ea9198d682238229df87256592211d62e5f ../objdirs/objdir-browser-artifact/dist/NightlyDebug.app/Contents/MacOS/updater.app/Contents/Frameworks/UpdateSettings.framework/UpdateSettings
and checking about:support yields default and the update channels allowed is '' (both as expected).
However a non-debug build doesn't seem right! It looks right:
$ cat mozconfig-browser-artifact
mk_add_options AUTOCLOBBER=1
ac_add_options --enable-application=browser
ac_add_options --enable-artifact-builds
mk_add_options MOZ_OBJDIR="../objdirs/objdir-browser-artifact"
$ find ../objdirs/objdir-browser-artifact -iname 'ChannelPrefs' -type file | xargs shasum
cdea24b5415891d7e149c94d7272cd5140e965b3 ../objdirs/objdir-browser-artifact/dist/update_framework_artifacts/ChannelPrefs-localbuild.framework/ChannelPrefs
cdea24b5415891d7e149c94d7272cd5140e965b3 ../objdirs/objdir-browser-artifact/dist/bin/ChannelPrefs.framework/ChannelPrefs
cdea24b5415891d7e149c94d7272cd5140e965b3 ../objdirs/objdir-browser-artifact/dist/Nightly.app/Contents/Frameworks/ChannelPrefs.framework/ChannelPrefs
$ find ../objdirs/objdir-browser-artifact -iname 'UpdateSettings' -type file | xargs shasum
e8c9e115905ab73044b5ead5b414d9cf632aec08 ../objdirs/objdir-browser-artifact/_tests/xpcshell/toolkit/mozapps/update/tests/data/updater.app/Contents/Frameworks/UpdateSettings.framework/UpdateSettings
e8c9e115905ab73044b5ead5b414d9cf632aec08 ../objdirs/objdir-browser-artifact/_tests/testing/mochitest/browser/toolkit/mozapps/update/tests/browser/updater.app/Contents/Frameworks/UpdateSettings.framework/UpdateSettings
5e3760506f06b0233dd9389e1a48e673fd28b5da ../objdirs/objdir-browser-artifact/dist/update_framework_artifacts/UpdateSettings-localbuild.framework/UpdateSettings
5e3760506f06b0233dd9389e1a48e673fd28b5da ../objdirs/objdir-browser-artifact/dist/bin/updater.app/Contents/Frameworks/UpdateSettings.framework/UpdateSettings
5e3760506f06b0233dd9389e1a48e673fd28b5da ../objdirs/objdir-browser-artifact/dist/Nightly.app/Contents/MacOS/updater.app/Contents/Frameworks/UpdateSettings.framework/UpdateSettings
but about:support yields nightly and:
$ /Users/nalexander/Mozilla/objdirs/objdir-browser-artifact/dist/Nightly.app/Contents/MacOS/updater.app/Contents/MacOS/org.mozilla.updater --channels-allowed
Error: 38
That last makes no sense to me, since it appears that UpdateSettings is in the right place. I'll run this down ASAP.
| Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
| Assignee | ||
Comment 1•2 years ago
|
||
My tree is based off of https://treeherder.mozilla.org/jobs?repo=mozilla-central&revision=a9f0952d79a4097d8d7f3daa05533fea8a74c8c9. The artifacts are fetched from https://firefox-ci-tc.services.mozilla.com/tasks/ELKNmeZQTJiAE_jEnEXIUQ. That's one of these macOS universal builds, which actually fetches artifacts from two locations, namely aarch64 bits from:
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/JMQhAlzXRUOiRPNhB0baXQ/artifacts/public/build/target.dmg
and x86_64 bits from:
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/GkkI5XgxShWUdnEthi3L6w/artifacts/public/build/target.dmg
Update framework artifacts were taken from
https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/GkkI5XgxShWUdnEthi3L6w/artifacts/public/build/target.update_framework_artifacts.zip which probably explains the issue -- we need aarch64 bits. We're failing to load it for the updater, and probably falling back to nightly in the product. I'll have to think about how to address this.
Comment 2•2 years ago
|
||
Set release status flags based on info from the regressing bug 1885985
Updated•2 years ago
|
| Assignee | ||
Comment 3•2 years ago
|
||
I think I understand what's happening here. The unifying part of a universal build is where we glue together x64 and aarch64 binaries using lipo. We do that for the DMGs that we ship but not for these developer framework artifacts. But there's nothing stopping us from unifying the binaries in the framework artifacts. I'll try to see how hard that is to arrange.
glandium: it's annoying to need this, but I don't see any reason to not unify these archives. Do you concur?
Comment 4•2 years ago
|
||
Yes. You're currently only taking the x86-64 part.
| Assignee | ||
Comment 5•2 years ago
|
||
| Assignee | ||
Comment 6•2 years ago
|
||
This looks good in https://treeherder.mozilla.org/jobs?repo=try&revision=3c5574b90954fdec9c70abbfffa879821ff97998, and a local artifact build with those artifacts does the right thing too.
Comment 8•2 years ago
|
||
| bugherder | ||
Description
•