1898639 - Crash in [@ mozilla::dom::MediaKeySession::CompleteGenerateRequest]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/cb6b4b03-6320-4996-9307-af86e0240523

Reason: EXCEPTION_ACCESS_VIOLATION_READ

Top 10 frames:

0  xul.dll  mozilla::dom::MediaKeySession::CompleteGenerateRequest(nsTString<char16_t> co...  dom/media/eme/MediaKeySession.cpp:321
1  xul.dll  mozilla::dom::MediaKeySession::GenerateRequest::<lambda_3>::operator()(mozill...  dom/media/eme/MediaKeySession.cpp:276
1  xul.dll  mozilla::MozPromise<bool, nsresult, 1>::InvokeMethod(mozilla::dom::MediaKeySe...  xpcom/threads/MozPromise.h:652
1  xul.dll  mozilla::MozPromise<bool, nsresult, 1>::InvokeCallbackMethod(mozilla::dom::Me...  xpcom/threads/MozPromise.h:683
1  xul.dll  mozilla::MozPromise<bool, nsresult, 1>::ThenValue<`lambda at /builds/worker/c...  xpcom/threads/MozPromise.h:922
2  xul.dll  mozilla::MozPromise<bool, nsresult, 1>::ThenValueBase::DoResolveOrReject(mozi...  xpcom/threads/MozPromise.h:621
2  xul.dll  mozilla::MozPromise<bool, nsresult, 1>::ThenValueBase::ResolveOrRejectRunnabl...  xpcom/threads/MozPromise.h:488
3  xul.dll  mozilla::RunnableTask::Run()  xpcom/threads/TaskController.cpp:580
3  xul.dll  mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::det...  xpcom/threads/TaskController.cpp:907
4  xul.dll  mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detai...  xpcom/threads/TaskController.cpp:730

Not a ton of these, but it looks like a null deref, so maybe there's an easy fix? The crash is on this line:
mKeys->GetCDMProxy()->CreateSession(Token(), mSessionType, pid, aInitDataType, aData);.

The previous line also uses mKeys, so maybe GetCDMProxy() is null? Most of the other uses of GetCDMProxy() do a null check, though MediaKeySession::Load also seems to not do one. I don't see any crashes with that in the signature, though.

Comment 1

[Alastor Wu [:alwu]]

Attachment: Bug 1898639 - check if CDM proxy still exists.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/473f4dc23d13
check if CDM proxy still exists. r=padenot

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/473f4dc23d13

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:alwu, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox127 to wontfix.

For more information, please visit BugBot documentation.