1898706 - Message vanishes when redoing moving from an IMAP folder

Status: VERIFIED FIXED

(MailNews Core :: Networking: IMAP, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

Steps to reproduce:

1. Move a message from an IMAP folder to a local folder.
2. Undo
3. Redo

Expected result:
The message is moved (again) into the local folder.

Actual result:
The message disappears.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Regression range
Likely regressed by bug 402392.

Comment 2

[Wayne Mery (:wsmwk)]

Hartmut, any idea what's going on?

Comment 3

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1898706 - Fix redo move/copy of messages from IMAP to local folder. r=benc

Bug 402392 changed the mechanism for restoring messages in local folders when performing an undo/redo operation. The old way was also retained and could be enabled by setting nsLocalMoveCopyMsgTxn::m_canUndelete, but this wasn't ever used.

This patch removes m_canUndelete and the code it covers, while fixing and simplifying the redo function.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f435b708a4bb
Fix redo move/copy of messages from IMAP to local folder. r=BenC

Comment 5

[Kai Engert [:KaiE:]]

Can you please briefly explain if this is relevant for 128, urgently or optionally ?

Comment 6

[Wayne Mery (:wsmwk)]

bug 402392 is version 12, so this should be an extremely old regression and I suggest it cannot be urgent.

Comment 7

[Hartmut Welpmann [:welpy-cw]]

(In reply to Wayne Mery (:wsmwk) from comment #6)

bug 402392 is version 12, so this should be an extremely old regression and I suggest it cannot be urgent.

Yes, this hasn't bothered anyone enough to report for over 12 years. Redo doesn't seem to be used that much.

Comment 8

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Confirming this issue as verified fixed with 133.0b3(20241107210012) using Windows 11, macOS 14, and Ubuntu 22.

Comment 9

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9430648 [details]
Bug 1898706 - Fix redo move/copy of messages from IMAP to local folder. r=benc

[Approval Request Comment]
Regression caused by (bug #): bug 402392
User impact if declined: Redoing a copy operation of messages from IMAP to a local folder removes the messages.
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): low

Comment 10

[Corey Bryant]

Comment on attachment 9430648 [details]
Bug 1898706 - Fix redo move/copy of messages from IMAP to local folder. r=benc

[Triage Comment]
Approved for esr128

Comment 11

[Corey Bryant]

Hartmut, This patch needs to be rebased in order to apply to 128. Can you take care of that and we can pick this up in the next point release?

Comment 12

[Kai Engert [:KaiE:]]

Attachment: 1898706-esr128.patch

here's the merged patch

Comment 13

[Kai Engert [:KaiE:]]

I haven't tested the merged patch.

Here is a try build with it:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=a56f585f2e8742476efbd0e5834f9ee4c0b53102

Could someone else check that the try build fixes the bug?

Comment 14

[Hartmut Welpmann [:welpy-cw]]

(In reply to Kai Engert [:KaiE:] from comment #13)

I haven't tested the merged patch.

Here is a try build with it:
https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=a56f585f2e8742476efbd0e5834f9ee4c0b53102

Could someone else check that the try build fixes the bug?

Thanks Kai. I tested the optimized Linux try build, the problem is fixed. I'll upload a slightly modified version of the patch that should fix the clang-format error.

Comment 15

[Hartmut Welpmann [:welpy-cw]]

Attachment: D225458.esr128.diff

Comment 16

[Corey Bryant]

Comment on attachment 9441783 [details] [diff] [review]
D225458.esr128.diff

[Triage Comment]
Approved for esr128

Comment 17

[Corey Bryant]

Comment on attachment 9430648 [details]
Bug 1898706 - Fix redo move/copy of messages from IMAP to local folder. r=benc

[Triage Comment]
Patch for esr128 is available as a separate attachment.

Comment 18

[Daniel Darnell [:dandarnell]]

Thunderbird 128.5.2esr:
https://hg.mozilla.org/releases/comm-esr128/rev/b093d4d597b6