1898736 - [wpt-sync] Sync PR 46475 - Replace GetDoubleValue with ConsumeNumber for rotate3d()

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46475 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46475
Details from upstream follow.

Daniil Sakhapov <[e-mail]> wrote:

Replace GetDoubleValue with ConsumeNumber for rotate3d()

Bug: 40946458
Change-Id: Ic21f7e533f26aeb3a7631dec329d7fa3d3f80585
Reviewed-on: https://chromium-review.googlesource.com/5569391
WPT-Export-Revision: cdc9192a90589ed36fea7f03a99bcde6bf39ae6b

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=4a37a3de3ea7ccbc330936dac86f830257d8e9ce

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 20 subtests

Status Summary

Firefox

OK : 1
FAIL : 20

Chrome

CRASH: 1

Safari

OK : 1
FAIL : 20

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-values/progress-computed.tentative.html [wpt.fyi]
  • progress(1 from 0 to 1) should be used-value-equivalent to 1: FAIL (Safari: FAIL)
  • progress(progress(1 from 0 to 1) from progress(0px from 0px to 1px) to progress(1deg from 0deg to 1deg)) should be used-value-equivalent to 1: FAIL (Safari: FAIL)
  • progress(sign(-10px) * 10px from (10px - 10px) to 10px * progress(1deg from 0deg to 1deg)) should be used-value-equivalent to -1: FAIL (Safari: FAIL)
  • calc(progress(100px from 0px to 50px) * 10px + 100px) should be used-value-equivalent to 120px: FAIL (Safari: FAIL)
  • calc(progress(100 from 0 to sign(50px))) should be used-value-equivalent to 100: FAIL (Safari: FAIL)
  • calc(progress(abs(5%) from hypot(3%, 4%) to 10%)) should be used-value-equivalent to 0: FAIL (Safari: FAIL)
  • progress(1000em from 10em to 110em) should be used-value-equivalent to 9.9: FAIL (Safari: FAIL)
  • scale(progress(1000em from 10rem to 110em)) should be used-value-equivalent to scale(9.9): FAIL (Safari: FAIL)
  • scale(progress(0em from 0rem to 0em)) should be used-value-equivalent to scale(0): FAIL (Safari: FAIL)
  • scale(progress(sign(1em - 1rem) * 1ex from 0rem to 0em)) should be used-value-equivalent to scale(0): FAIL (Safari: FAIL)
  • calc(progress(1 from 0 to 1) * 10px) should be used-value-equivalent to 10px: FAIL (Safari: FAIL)
  • calc(progress(1 from 0 to 1) * 1s) should be used-value-equivalent to 1s: FAIL (Safari: FAIL)
  • calc(progress(1 from 0 to 1) * 1deg) should be used-value-equivalent to 1deg: FAIL (Safari: FAIL)
  • calc(progress(sign(1001em - 10lh * progress(100px from 2rex to 10ex)) * 10em from 2rem to 12em) / 2) should be used-value-equivalent to 0.4: FAIL (Safari: FAIL)
  • calc(progress(sign(1001em - 10lh * progress(100px from 2rex to 10ex)) * 20em from 2rem to 12em) * 10) should be used-value-equivalent to 18: FAIL (Safari: FAIL)
  • calc(progress(sign(1001em - 10lh * progress(100px from 2rex to 10ex)) * 20em from 2rem to 12em) * 30) should be used-value-equivalent to 54: FAIL (Safari: FAIL)
  • calc(progress(sign(1001em - 10lh * progress(100px from 2rex to 10ex)) * 20em from 2rem to 12em) / 4) should be used-value-equivalent to 0.45: FAIL (Safari: FAIL)
  • calc(progress(sign(1001em - 10lh * progress(100px from 2rex to 10ex)) * 20em from 2rem to 12em) * 4) should be used-value-equivalent to 7: FAIL (Safari: FAIL)
  • calc(progress(sign(1001em - 10lh * progress(100px from 2rex to 10ex)) * 20em from 2rem to 12em) * 2) should be used-value-equivalent to 3.6: FAIL (Safari: FAIL)
  • rotate3d(progress(21em from 1rem to 11em), progress(21em from 1rem to 11em), progress(21em from 1rem to 11em), calc(progress(11em from 1rem to 11em) * 2deg)) should be used-value-equivalent to rotate3d(2, 2, 2, 2deg): FAIL (Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be6e56c673eb
[wpt PR 46475] - Replace GetDoubleValue with ConsumeNumber for rotate3d(), a=testonly
https://hg.mozilla.org/integration/autoland/rev/e3be6ad608e9
[wpt PR 46475] - Update wpt metadata, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/be6e56c673eb
https://hg.mozilla.org/mozilla-central/rev/e3be6ad608e9