Closed Bug 1898760 Opened 1 month ago Closed 24 days ago

[wpt-sync] Sync PR 46477 - [PEPC] Clamp min-width/height based on the maximum allowed value as well

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
128 Branch
Tracking Flags:
Tracking Status
firefox128 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 46477 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46477
Details from upstream follow.

Andy Paicu <andypaicu@chromium.org> wrote:

[PEPC] Clamp min-width/height based on the maximum allowed value as well

The min/max-width/height properties for the permission element are
bounded in an effort to prevent the width/height from going above/below
certain hard-set limits. However the min-width/height will overrule
the max-width/height if it's bigger. This means that the current
restrictions can be bypassed in one direction by setting the
min-width/height to very large values, as they are currently only lower
bounded (restricted from being too small). This CL instead changes the
logic to clamp the min-width/height so that it also has an upper bound.

Fixed: 341947676
Change-Id: I6fe68b6d9f07e4041e5c4455fc34dce167b01be5
Reviewed-on: https://chromium-review.googlesource.com/5563906
WPT-Export-Revision: 23d56808257863725a04a2b7629928ad637bb12a

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 3

Chrome

OK : 1
PASS: 2
FAIL: 2

Safari

OK : 1
PASS: 1
FAIL: 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /html/semantics/permission-element/bounded-sizes.tentative.html [wpt.fyi]
    • Properties with out-of-bounds values should be corrected: FAIL (Chrome: PASS, Safari: FAIL)
    • Properties with values in bounds should not be modified: FAIL (Chrome: PASS, Safari: FAIL)
    • 'Min' properties should not be allowed to go over the maximum allowed values for 'max' properties: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cfe7c58b0112
[wpt PR 46477] - [PEPC] Clamp min-width/height based on the maximum allowed value as well, a=testonly
https://hg.mozilla.org/integration/autoland/rev/cf882271e7c3
[wpt PR 46477] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/cfe7c58b0112
https://hg.mozilla.org/mozilla-central/rev/cf882271e7c3

Status: NEW → RESOLVED
Closed: 24 days ago
status-firefox128: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.