1898777 - get_outgoing_files should raise a MissingUpstreamRepo exception for undetected VCS

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

When the mozversioncontrol module doesn't know what upstream is because it's detected a repo as src, I'd suggest it'd be better if get_outgoing_files threw MissingUpstreamRepo

Otherwise, mach clang-format fails in is_unmodified_mach_core, even if you are providing the path.

(Context, I am experimenting with Sapling, but this generally would be an issue for any time an SrcRepository is the determined type. )

Comment 1

[Matthew Gaudet (he/him) [:mgaudet]]

Attachment: Bug 1898777 - Throw MissingUpstreamRepo from SrcRepository when calling get_outgoing_files r?ahochheiden

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ca4946dc925
Throw MissingUpstreamRepo from SrcRepository when calling get_outgoing_files r=ahochheiden

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5ca4946dc925