Closed
Bug 1898777
Opened 25 days ago
Closed 24 days ago
get_outgoing_files should raise a MissingUpstreamRepo exception for undetected VCS
Categories
(Firefox Build System :: Mach Core, enhancement)
Firefox Build System
Mach Core
Tracking
(firefox128 fixed)
RESOLVED
FIXED
128 Branch
| Tracking | Status | |
|---|---|---|
| firefox128 | --- | fixed |
People
(Reporter: mgaudet, Assigned: mgaudet)
Details
Attachments
(1 file)
When the mozversioncontrol module doesn't know what upstream is because it's detected a repo as src, I'd suggest it'd be better if get_outgoing_files threw MissingUpstreamRepo
Otherwise, mach clang-format fails in is_unmodified_mach_core, even if you are providing the path.
(Context, I am experimenting with Sapling, but this generally would be an issue for any time an SrcRepository is the determined type. )
|
Assignee | |
Comment 1•25 days ago
|
||
|
||
Updated•25 days ago
|
Assignee: nobody → mgaudet
Status: NEW → ASSIGNED
Pushed by mgaudet@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5ca4946dc925 Throw MissingUpstreamRepo from SrcRepository when calling get_outgoing_files r=ahochheiden
|
||
Comment 3•24 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 24 days ago
status-firefox128:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•