1898816 - Missing focus indicators for buttons in footer of software update screen - macOS

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect, P2)

Description

[Anna Yeddi [:ayeddi]]

Attachment: Footer buttons have invisible focus indication

The focus indication is missing for the following buttons in the footer of the Software Update Screen:

1. Restart Later
2. No Thanks
3. Restart Nightly

Missing focus indications make it hard to navigate the interface for keyboard-only users, especially for those who does not have any other assistive technology running (because screen readers and magnification software, among others, would also provide a custom focus indication overlay) - it is hard to predict where the current focus position is, which control would be activated when Enter is pressed, if any would be activated at all.

Providing an outline for the :focus or :focus-visible state is an expected focus position indication. It seems that the focus indication has a negative offset (per triggering the dialog on Windows)

Note:

To trigger the dialog, the two most common ways are to:

1. update Firefox as a limited user instead of as an administrator or
2. this can also happen on the first update after installing from a .pkg
   Or open the browser console and run Services.ww.openWindow(null, "chrome://mozapps/content/update/updateElevation.xhtml", "Update:Elevation", "chrome,centerscreen,resizable=no,titlebar,toolbar=no,dialog=no", null)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:erchen, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 2

[Eric Chen]

Attachment: Bug 1898816 - adding missing focus indicators to software update popup buttons

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27bc0e4cc3f6
adding missing focus indicators to software update popup buttons r=accessibility-frontend-reviewers,desktop-theme-reviewers,ayeddi,dao

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/27bc0e4cc3f6