1898837 - Review Checker Auto-open toggle does not respect Turned-off Auto-open selection after manually opening up the RC sidebar

Status: NEW

(Firefox :: Shopping, defect, P2)

Description

[jchen]

SUMMARY

• Review Checker V1.1 does not respect a turned-off auto-open toggle after a user manually opens Review Checker again from the address bar shopping icon affordance. What results is that RC "auto-opens" even after the user has elected to turn off "auto-open" -- potentially annoying the user.

VERSION DETAILS

• Firefox Nightly 128
• about:config and nimbus.debug configured TRUE
• Pref on for the Review Checker V1.1 Treatment A experience via about:studies?optin_slug=us-review-checker-rollout&optin_branch=treatment-a&optin_collection=nimbus-preview

STEPS TO REPRODUCE

• Go to Amazon, Walmart, or Best Buy product detail page (PDP)
• Review Checker should appear in its sidebar on the right with a button to "yes, try it." Click the button to opt in
• On PDPs, the RC should auto-open by default by itself.
• Now, turn off the toggle in the Review Checker that says, "Automatically open Review Checker." RC should not open by itself on PDPs from now on.
• Go to another PDP, but this time manually open the Review Checker from the Shopping Icon in the Address bar.
• You should see that the "Automatically open Review Checker" toggle is off, since you turned it off previously.
• Go to other PDPs. Notice that the Review Checker opens automatically, even though the "Automatically open Review Checker"toggle is off.

EXPECTED BEHAVIOR

• You should never be able to see a Review Checker popping open automatically if you have toggled off Auto-open.
• If the Review Checker's Auto-open capability is Off, and you manually open the Review Checker once, the sidebar opens, but it should NOT auto-open the next PDP you visit.

ACTUAL BEHAVIOR

• Review Checker auto-opens after you manually opened Review Checker again on PDPs. It does not appear to respect the fact you toggled Auto-open off.

Comment 1

[Joe McBride]

@jchen I tried to reproduce this but was unsuccessful. I was using Nightly 128.0a1 (2024-05-28) (64-bit).

Comment 2

[jchen]

I was able to reproduce on another install of Nightly and the 1.1 experience pref'd on.

Adding a Severity tag at Julien's recommendation - I think it is S2 in relation to the feature, given it seems to be broken functionality that in particular causes the Review Checker to pop up automatically more often than it should, potentially causing annoyance.

Comment 3

[Joe McBride]

I was able to reproduce. There are 2 scenarios to watch out for on this:

1. auto-open toggle off AND review checker open on a PDP --> automatically displays on other PDPs
2. auto-open toggle off AND review checker closed on the current PDP --> does not display the PDP on other pages

This is not ideal, but I have noted the current behavior auto closes review checker after one toggles auto-open. That means this will only impact users that toggle it off, activate it from the URL bar AND leave it open to search other product pages.

Comment 4

[jchen]

Adding a priority at Julien's recommendation - given a core functionality, Auto-open, of the V1.1 is broken (the Review Checker should never auto-open if the user has already toggled off Auto-Open and if the Auto-open toggle is set to off), deeming it a P1 with respect to the Review Checker functionality.

cc @julien

Comment 5

[:Gijs (out for now; he/him)]

I think the current behaviour is expected.

https://docs.google.com/document/d/1FwVuPG3Osf43Iti09ciRP1UCXxJl_e869GZr2OL2yM8/edit#heading=h.4nlymp6oyn8p has the original spec for auto-open.

The behaviour at issue here is with auto-open turned off. The doc says:

Today, the desktop sidebar is a global toggle such that if a user closes it once:

• On any tab, the sidebar closes in all tabs and windows.
• RC stays closed until the user clicks the URL bar shopping icon again.

(the doc doesn't make this explicit, but I would add "and then would be open on each [PDP] tab, because it's a global toggle")

This is what the actual behaviour from comment 0 shows: once you reopen (by clicking the shopping price tag icon), the sidebar is open everywhere you load PDP. Once you were to close it on any of these PDPs (by clicking the [x] in the sidebar, or the price tag icon with the sidebar open), the sidebar closes.

This global-toggle-ness of the behaviour, irrespective of auto-open, is hard to change at this point in time. There was a previous eng doc on this issue. I don't think changing the behaviour to be per-tab or otherwise more granular should be in scope for shipping, and I don't think the P1/S2 state of this bug reflects the severity of the issue.

Comment 6

[jchen]

Updating to P2 - we can reassign this as not being a launch blocker for Review Checker.

Comment 7

[:Gijs (out for now; he/him)]

Moving this to the bug collecting things we do want to do but have decided won't block 100% US rollout, per slack discussion.