1898887 - Implement parsing of CSS 'inset-area' property (subsequently renamed 'position-area`)

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Jonathan Watt [:jwatt]]

Defined as:

none | <inset-area>

<inset-area> = [
  [ left | right | span-left | span-right
  | x-start | x-end | span-x-start | span-x-end
  | x-self-start | x-self-end | span-x-self-start | span-x-self-end
    | center | span-all ]
  ||
  [ top | bottom | span-top | span-bottom
  | y-start | y-end | span-y-start | span-y-end
  | y-self-start | y-self-end | span-y-self-start | span-y-self-end
    | center | span-all ]
|
  [ block-start | block-end | span-block-start | span-block-end
    | center | span-all ]
  ||
  [ inline-start | inline-end | span-inline-start | span-inline-end
    | center| span-all ]
|
  [ self-block-start | self-block-end | span-self-block-start | span-self-block-end
    | span-all ]
  ||
  [ self-inline-start | self-inline-end | span-self-inline-start | span-self-inline-end
    | span-all ]
|
  [ start | end | span-start | span-end
    | center | span-all ]{1,2}
|
  [ self-start | self-end | span-self-start | span-self-end
    | center | span-all ]{1,2}
]

Comment 1

[Jonathan Watt [:jwatt]]

Giving my own names to the components of each of these five span types, I might have:

[
  <horizontal-span> || <vertical-span>
  |
  <logical-block-span> || <logical-inline-span>
  |
  <logical-block-span-self> || <logical-inline-span-self>
  |
  <inferred-span>{1,2}
  |
  <inferred-span-self>{1,2}
]

Note that each of the five span types have unique keywords, except for the common keywords center and span-all.

My plan for implementing these is to create five sub-types in Rust code (one for each row above), implemented with bitflags!(). My current names are:

InsetAreaSpanAxis
InsetAreaSpanLogical
InsetAreaSpanLogicalSelf
InsetAreaSpanInferred
InsetAreaSpanInferredSelf

The InsetArea type is then an enum of these five types.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: WIP: Bug 1898887. WIP approach using bitflags.

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: Bug 1898887. Implement parsing of CSS 'inset-area' property. r=emilio

Comment 4

[Jonathan Watt [:jwatt]]

Attachment: Bug 1898887 p2. Enable layout.css.anchor-positioning.enabled for css/css-anchor-position/inset-area-parsing.html. r=emilio

Depends on D211955

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a567d2740874
Implement parsing of CSS 'inset-area' property. r=emilio,firefox-style-system-reviewers
https://hg.mozilla.org/integration/autoland/rev/d7b6d89a795e
p2. Enable layout.css.anchor-positioning.enabled for css/css-anchor-position/inset-area-parsing.html. r=emilio

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a567d2740874
https://hg.mozilla.org/mozilla-central/rev/d7b6d89a795e