1898891 - Move captive portal detection to an endpoint that returns 204

Status: RESOLVED FIXED

(Core :: Networking, enhancement, P3)

Description

[Valentin Gosu [:valentin]]

(In reply to tim from bug 1887714 comment #15)

I tried both of those builds and both seem to work with no captive portal detection.

It seems an endpoint that responds with a 204 status would generate fewer false positives.
We should investigate how easy that is to achieve on the server-side.

Comment 1

[Valentin Gosu [:valentin]]

Attachment: Bug 1898891 - Use 204 returning captive portal endpoint r=#necko

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f394c1bf2d76
https://hg.mozilla.org/integration/autoland/rev/fa4dd8de7d5e
Use 204 returning captive portal endpoint r=necko-reviewers,kershaw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6184ebc5afbc
https://hg.mozilla.org/integration/autoland/rev/da6e5addb528
Revert "Bug 1898891 - Use 204 returning captive portal endpoint r=necko-reviewers,kershaw" for causing xpcshell failures in test_ext_captivePortal.js.

Comment 4

[Serban Stanca [:SerbanS]]

Reverted this because it was causing xpcshell failures in test_ext_captivePortal.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | xpcshell-remote.toml:toolkit/components/extensions/test/xpcshell/test_ext_captivePortal.js | Test timed out; open profile_test_ext_captivePortal_retry.js.json in the Firefox Profiler

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/be5466ce6dc9
https://hg.mozilla.org/integration/autoland/rev/77dab6da56c6
Use 204 returning captive portal endpoint r=necko-reviewers,kershaw,extension-reviewers,robwu

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/77dab6da56c6

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9cae66f7ed95
https://hg.mozilla.org/integration/autoland/rev/44adf8fbd1af
Revert "Bug 1898891 - Use 204 returning captive portal endpoint r=necko-reviewers,kershaw,extension-reviewers,robwu" at dev request for causing Bug 2052715

Comment 8

[Silaghi Andreea]

Backout as requested by dev for causing Bug 2052715 https://hg.mozilla.org/integration/autoland/rev/44adf8fbd1af

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9686c7a6c915
https://hg.mozilla.org/integration/autoland/rev/fe2c6ddcc4bc
Use 204 returning captive portal endpoint r=necko-reviewers,kershaw,extension-reviewers,robwu

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fe2c6ddcc4bc

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for the Fx155 relnotes? If so, set the relnote-firefox flag to "?"
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Possible wording:

Firefox now uses firefox-portal-detection.com instead of detectportal.firefox.com to detect captive portals and check network connectivity, so network allowlists referencing the old domain need updating.

Comment 12

[Valentin Gosu [:valentin]]

I'll nominate for relnote in bug 2049252 instead.