189903 - preferences off the edge of dialog box

Status: RESOLVED FIXED

(Calendar :: Preferences, defect)

Description

[Tim Davenport]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2.1) Gecko/20021130

the calendar preferences page does not fit in the size of the preferences box
the righthand side is cropped.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Tim Davenport]

Attachment: Added flex"1" to textbox fields

I have added flex="1" to the textbox fields and reduced the overall length of
the defaultendhour description string

Comment 2

[Brant Gurganus]

Confirmed

Tim, when you create a patch, use the command 'cvs diff -u (filename)'.  Also,
mark you patches for review by mikep or, if for the back end, mostafah.

Comment 3

[Tim Davenport]

Attachment: screenshot

Comment 4

[Tim Davenport]

Bug fix attached

Comment 5

[Tim Davenport]

Attachment: Screenshot1 of proposed prefs changes

Comment 6

[Tim Davenport]

Attachment: Screenshot2 of proposed prefs changes

Comment 7

[Tim Davenport]

Attachment: patched with cvs diff -wb prefs.dtd

cvs diff -wb prefs.dtd (in directory
F:\davti\mozilla_xul\mozilla\mozilla\calendar\resources\locale\en-US)
Index: prefs.dtd
===================================================================
RCS file: /cvsroot/mozilla/calendar/resources/locale/en-US/prefs.dtd,v
retrieving revision 1.8
diff -w -b -r1.8 prefs.dtd
43a44
> <!ENTITY calendar.views.label       "Views">
62a64,89
> 
> <!ENTITY pref.hour.help.description	 "Overwritten if events are outside
these times" >
> <!ENTITY pref.hour.00    "00:00" >
> <!ENTITY pref.hour.01    "01:00" >
> <!ENTITY pref.hour.02    "02:00" >
> <!ENTITY pref.hour.03    "03:00" >
> <!ENTITY pref.hour.04    "04:00" >
> <!ENTITY pref.hour.05    "05:00" >
> <!ENTITY pref.hour.06    "06:00" >
> <!ENTITY pref.hour.07    "07:00" >
> <!ENTITY pref.hour.08    "08:00" >
> <!ENTITY pref.hour.09    "09:00" >
> <!ENTITY pref.hour.10    "10:00" >
> <!ENTITY pref.hour.11    "11:00" >
> <!ENTITY pref.hour.12    "12:00" >
> <!ENTITY pref.hour.13    "13:00" >
> <!ENTITY pref.hour.14    "14:00" >
> <!ENTITY pref.hour.15    "15:00" >
> <!ENTITY pref.hour.16    "16:00" >
> <!ENTITY pref.hour.17    "17:00" >
> <!ENTITY pref.hour.18    "18:00" >
> <!ENTITY pref.hour.19    "19:00" >
> <!ENTITY pref.hour.20    "20:00" >
> <!ENTITY pref.hour.21    "21:00" >
> <!ENTITY pref.hour.22    "22:00" >
> <!ENTITY pref.hour.23    "23:00" >

Comment 8

[Tim Davenport]

Attachment: patched with cvs diff -wb calendarPref.xul

cvs diff -wb calendarPref.xul (in directory
F:\davti\mozilla_xul\mozilla\mozilla\calendar\resources\content\pref)
Index: calendarPref.xul
===================================================================
RCS file: /cvsroot/mozilla/calendar/resources/content/pref/calendarPref.xul,v
retrieving revision 1.19
diff -w -b -r1.19 calendarPref.xul
85,86c85
<	   "dateformat", "weekstarts", "defaultlength", "defaultsnoozelength",
<	   "reloadonlaunch", "categories", "daystarthour", "dayendhour"
---
>	"dateformat", "defaultlength", "defaultsnoozelength", "reloadonlaunch",
"categories"
101,124d99
<	
<	<hbox>
<	   <description>&pref.weekstarts.label;</description>
<	   <menulist id="weekstarts" prefstring="calendar.week.start">
<	    <menupopup id="weekstarts">
<	      <menuitem label="&pref.weekstarts.sunday;"    value="0"/>
<	      <menuitem label="&pref.weekstarts.monday;"    value="1"/>
<	      <menuitem label="&pref.weekstarts.tuesday;"   value="2"/>
<	      <menuitem label="&pref.weekstarts.wednesday;" value="3"/>
<	      <menuitem label="&pref.weekstarts.thursday;"  value="4"/>
<	      <menuitem label="&pref.weekstarts.friday;"    value="5"/>
<	      <menuitem label="&pref.weekstarts.saturday;"  value="6"
selected="true"/>
<	    </menupopup>
<	  </menulist>	
<	</hbox>
<	
<	<hbox align="center">
<	   <description>Unless there are events, restrict day view to
</description>
<	   <textbox id="daystarthour" preftype="int"
prefstring="calendar.event.defaultstarthour" maxlength="2" size="2" value="8"/>

<	   <description>:00 and </description>
<	   <textbox id="dayendhour" preftype="int"
prefstring="calendar.event.defaultendhour" maxlength="2" size="2" value="17"/>
<	   <description>:00 ( 0 - 24 ) </description>
<	</hbox>
<	
127c102
<	   <textbox id="defaultlength" preftype="int"
prefstring="calendar.event.defaultlength" maxlength="3" size="3"/>
---
>	   <textbox flex="1" id="defaultlength" preftype="int"
prefstring="calendar.event.defaultlength" maxlength="3" size="3"/>
133c108
<	   <textbox id="defaultsnoozelength" preftype="int"
prefstring="calendar.alarms.defaultsnoozelength" maxlength="3" size="3"/>
---
>	   <textbox flex="1" id="defaultsnoozelength" preftype="int"
prefstring="calendar.alarms.defaultsnoozelength" maxlength="3" size="3"/>
143c118
<	   <description
flex="1">&pref.categories.help.description;</description>
---
>		 <description>&pref.categories.help.description;</description>

Comment 9

[Tim Davenport]

Attachment: patched with cvs diff -wb prefOverlay.xul

cvs diff -wb prefOverlay.xul (in directory
F:\davti\mozilla_xul\mozilla\mozilla\calendar\resources\content\pref)
Index: prefOverlay.xul
===================================================================
RCS file: /cvsroot/mozilla/calendar/resources/content/pref/prefOverlay.xul,v
retrieving revision 1.8
diff -w -b -r1.8 prefOverlay.xul
79a80,84
>	  <treeitem id="calendarPublishPanel" container="false">
>	   <treerow>
>		 <treecell class="treecell-indent"
url="chrome://calendar/content/pref/viewPrefs.xul"
label="&calendar.views.label;" id="calendarView"/>
>	   </treerow>
>	</treeitem>

Comment 10

[Tim Davenport]

Attachment: New prefs screen

This file has the views seperated out into another screen

Comment 11

[Tim Davenport]

I have redesigned the prefs screens and added anothe branch for the calendar
view prefs, with enoug room for extra prefs for day, week & month views

Comment 12

[Mike Potter]

The patches should be done with cvs diff -u
Can you make the patches again.  You could put them all into one file this time.

Comment 13

[Tim Davenport]

Attachment: diff file + new file in a gzipped tar file

package the diff files along with one new one hope this is now in the correct
format for you to use

Comment 14

[Tim Davenport]

Re pachaged the patch in the correct format (I hope)

Comment 15

[Mike Potter]

That worked great.
It looks much better too, its been checked into cvs.

Comment 16

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!