preferences off the edge of dialog box

RESOLVED FIXED

Status

Calendar
Preferences
--
minor
RESOLVED FIXED
15 years ago
11 years ago

People

(Reporter: Tim Davenport, Assigned: Mike Potter)

Tracking

Details

Attachments

(4 attachments, 5 obsolete attachments)

(Reporter)

Description

15 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2.1) Gecko/20021130
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.2.1) Gecko/20021130

the calendar preferences page does not fit in the size of the preferences box
the righthand side is cropped.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
(Reporter)

Comment 1

15 years ago
Created attachment 112146 [details] [diff] [review]
Added flex"1" to textbox fields

I have added flex="1" to the textbox fields and reduced the overall length of
the defaultendhour description string

Comment 2

15 years ago
Confirmed

Tim, when you create a patch, use the command 'cvs diff -u (filename)'.  Also,
mark you patches for review by mikep or, if for the back end, mostafah.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Comment 3

15 years ago
Created attachment 112221 [details]
screenshot
(Reporter)

Comment 4

15 years ago
Bug fix attached
(Reporter)

Comment 5

15 years ago
Created attachment 112384 [details]
Screenshot1 of proposed prefs changes
Attachment #112146 - Attachment is obsolete: true
(Reporter)

Comment 6

15 years ago
Created attachment 112386 [details]
Screenshot2 of proposed prefs changes
(Reporter)

Comment 7

15 years ago
Created attachment 112387 [details] [diff] [review]
patched  with cvs diff -wb prefs.dtd

cvs diff -wb prefs.dtd (in directory
F:\davti\mozilla_xul\mozilla\mozilla\calendar\resources\locale\en-US)
Index: prefs.dtd
===================================================================
RCS file: /cvsroot/mozilla/calendar/resources/locale/en-US/prefs.dtd,v
retrieving revision 1.8
diff -w -b -r1.8 prefs.dtd
43a44
> <!ENTITY calendar.views.label       "Views">
62a64,89
> 
> <!ENTITY pref.hour.help.description	 "Overwritten if events are outside
these times" >
> <!ENTITY pref.hour.00    "00:00" >
> <!ENTITY pref.hour.01    "01:00" >
> <!ENTITY pref.hour.02    "02:00" >
> <!ENTITY pref.hour.03    "03:00" >
> <!ENTITY pref.hour.04    "04:00" >
> <!ENTITY pref.hour.05    "05:00" >
> <!ENTITY pref.hour.06    "06:00" >
> <!ENTITY pref.hour.07    "07:00" >
> <!ENTITY pref.hour.08    "08:00" >
> <!ENTITY pref.hour.09    "09:00" >
> <!ENTITY pref.hour.10    "10:00" >
> <!ENTITY pref.hour.11    "11:00" >
> <!ENTITY pref.hour.12    "12:00" >
> <!ENTITY pref.hour.13    "13:00" >
> <!ENTITY pref.hour.14    "14:00" >
> <!ENTITY pref.hour.15    "15:00" >
> <!ENTITY pref.hour.16    "16:00" >
> <!ENTITY pref.hour.17    "17:00" >
> <!ENTITY pref.hour.18    "18:00" >
> <!ENTITY pref.hour.19    "19:00" >
> <!ENTITY pref.hour.20    "20:00" >
> <!ENTITY pref.hour.21    "21:00" >
> <!ENTITY pref.hour.22    "22:00" >
> <!ENTITY pref.hour.23    "23:00" >
(Reporter)

Comment 8

15 years ago
Created attachment 112388 [details] [diff] [review]
patched with cvs diff -wb calendarPref.xul 

cvs diff -wb calendarPref.xul (in directory
F:\davti\mozilla_xul\mozilla\mozilla\calendar\resources\content\pref)
Index: calendarPref.xul
===================================================================
RCS file: /cvsroot/mozilla/calendar/resources/content/pref/calendarPref.xul,v
retrieving revision 1.19
diff -w -b -r1.19 calendarPref.xul
85,86c85
<	   "dateformat", "weekstarts", "defaultlength", "defaultsnoozelength",
<	   "reloadonlaunch", "categories", "daystarthour", "dayendhour"
---
>	"dateformat", "defaultlength", "defaultsnoozelength", "reloadonlaunch",
"categories"
101,124d99
<	
<	<hbox>
<	   <description>&pref.weekstarts.label;</description>
<	   <menulist id="weekstarts" prefstring="calendar.week.start">
<	    <menupopup id="weekstarts">
<	      <menuitem label="&pref.weekstarts.sunday;"    value="0"/>
<	      <menuitem label="&pref.weekstarts.monday;"    value="1"/>
<	      <menuitem label="&pref.weekstarts.tuesday;"   value="2"/>
<	      <menuitem label="&pref.weekstarts.wednesday;" value="3"/>
<	      <menuitem label="&pref.weekstarts.thursday;"  value="4"/>
<	      <menuitem label="&pref.weekstarts.friday;"    value="5"/>
<	      <menuitem label="&pref.weekstarts.saturday;"  value="6"
selected="true"/>
<	    </menupopup>
<	  </menulist>	
<	</hbox>
<	
<	<hbox align="center">
<	   <description>Unless there are events, restrict day view to
</description>
<	   <textbox id="daystarthour" preftype="int"
prefstring="calendar.event.defaultstarthour" maxlength="2" size="2" value="8"/>

<	   <description>:00 and </description>
<	   <textbox id="dayendhour" preftype="int"
prefstring="calendar.event.defaultendhour" maxlength="2" size="2" value="17"/>
<	   <description>:00 ( 0 - 24 ) </description>
<	</hbox>
<	
127c102
<	   <textbox id="defaultlength" preftype="int"
prefstring="calendar.event.defaultlength" maxlength="3" size="3"/>
---
>	   <textbox flex="1" id="defaultlength" preftype="int"
prefstring="calendar.event.defaultlength" maxlength="3" size="3"/>
133c108
<	   <textbox id="defaultsnoozelength" preftype="int"
prefstring="calendar.alarms.defaultsnoozelength" maxlength="3" size="3"/>
---
>	   <textbox flex="1" id="defaultsnoozelength" preftype="int"
prefstring="calendar.alarms.defaultsnoozelength" maxlength="3" size="3"/>
143c118
<	   <description
flex="1">&pref.categories.help.description;</description>
---
>		 <description>&pref.categories.help.description;</description>
(Reporter)

Comment 9

15 years ago
Created attachment 112389 [details] [diff] [review]
patched with cvs diff -wb prefOverlay.xul

cvs diff -wb prefOverlay.xul (in directory
F:\davti\mozilla_xul\mozilla\mozilla\calendar\resources\content\pref)
Index: prefOverlay.xul
===================================================================
RCS file: /cvsroot/mozilla/calendar/resources/content/pref/prefOverlay.xul,v
retrieving revision 1.8
diff -w -b -r1.8 prefOverlay.xul
79a80,84
>	  <treeitem id="calendarPublishPanel" container="false">
>	   <treerow>
>		 <treecell class="treecell-indent"
url="chrome://calendar/content/pref/viewPrefs.xul"
label="&calendar.views.label;" id="calendarView"/>
>	   </treerow>
>	</treeitem>
(Reporter)

Comment 10

15 years ago
Created attachment 112390 [details] [diff] [review]
New prefs screen

This file has the views seperated out into another screen
(Reporter)

Comment 11

15 years ago
I have redesigned the prefs screens and added anothe branch for the calendar
view prefs, with enoug room for extra prefs for day, week & month views
(Assignee)

Comment 12

15 years ago
The patches should be done with cvs diff -u
Can you make the patches again.  You could put them all into one file this time.
(Reporter)

Comment 13

15 years ago
Created attachment 112465 [details] [diff] [review]
diff file + new file in a gzipped tar file

package the diff files along with one new one hope this is now in the correct
format for you to use
Attachment #112387 - Attachment is obsolete: true
Attachment #112388 - Attachment is obsolete: true
Attachment #112389 - Attachment is obsolete: true
Attachment #112390 - Attachment is obsolete: true
(Reporter)

Comment 14

15 years ago
Re pachaged the patch in the correct format (I hope)
(Assignee)

Comment 15

15 years ago
That worked great.
It looks much better too, its been checked into cvs.
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!
QA Contact: gurganbl → sunbird

Updated

11 years ago
Component: Sunbird Only → Preferences
QA Contact: sunbird → preferences
You need to log in before you can comment on or make changes to this bug.