Closed Bug 1899117 Opened 6 months ago Closed 29 days ago

Add telemetry for uploads file metadata telemetry

Tracking

()

Status:

RESOLVED FIXED

Milestone:

134 Branch

Tracking Flags:

Tracking

Status

firefox134

---

fixed

People

(Reporter: leander.schwarz, Assigned: leander.schwarz)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

WIP: Bug 1899117 - Add file and input type telemetry for EXIF metadata stripper project. r?bvandersloot 2 months ago Leander Schwarz 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1899117 - Enable MockFilePicker mode selection. r?bvandersloot 1 month ago Leander Schwarz 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1899117 - Add file and input type telemetry for EXIF metadata stripper project. r?bvandersloot 1 month ago Leander Schwarz 48 bytes, text/x-phabricator-request		Details \| Review

Leander Schwarz

Assignee

Description

•

6 months ago

No description provided.

Leander Schwarz

Assignee

Comment 1

•

2 months ago

Attached file WIP: Bug 1899117 - Add file and input type telemetry for EXIF metadata stripper project. r?bvandersloot (obsolete) — Details

Leander Schwarz

Assignee

Comment 2

•

1 month ago

Attached file Bug 1899117 - Enable MockFilePicker mode selection. r?bvandersloot (obsolete) — Details

Leander Schwarz

Assignee

Comment 3

•

1 month ago

Attached file Bug 1899117 - Add file and input type telemetry for EXIF metadata stripper project. r?bvandersloot — Details

Depends on D226523

Phabricator Automation

Updated

•

1 month ago

Attachment #9426789 - Attachment is obsolete: true

Pulsebot

Comment 4

•

1 month ago

Pushed by lschwarz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/270d18416ca7 Enable MockFilePicker mode selection. r=bvandersloot https://hg.mozilla.org/integration/autoland/rev/814c8b5c6837 Add file and input type telemetry for EXIF metadata stripper project. r=bvandersloot,anti-tracking-reviewers

amarc

Comment 5

•

1 month ago

•

Edited

Backed out for causing py3 failures @ test_yaml_indices.py::test_yamls_sorted

[task 2024-10-29T08:00:31.975Z] toolkit/components/glean/tests/pytest/test_no_expired_metrics.py::test_no_metrics_expired PASSED
[task 2024-10-29T08:00:31.975Z] 
[task 2024-10-29T08:00:31.975Z] ============================== 1 passed in 8.43s ===============================
[task 2024-10-29T08:00:31.975Z] 
[task 2024-10-29T08:00:31.975Z] 
[task 2024-10-29T08:00:31.975Z] Tests Completed: 100%|██████████| 7/7 [00:10<00:00,  2.25s/Test]
[task 2024-10-29T08:00:31.976Z]                                                                 
[task 2024-10-29T08:00:31.976Z] /builds/worker/checkouts/gecko/toolkit/components/glean/tests/pytest/test_yaml_indices.py
[task 2024-10-29T08:00:31.976Z] ============================= test session starts ==============================
[task 2024-10-29T08:00:31.976Z] platform linux -- Python 3.8.10, pytest-7.0.1, pluggy-1.5.0 -- /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/python-test/bin/python
[task 2024-10-29T08:00:31.976Z] rootdir: /builds/worker/checkouts/gecko, configfile: config/mozunit/mozunit/pytest.ini
[task 2024-10-29T08:00:31.976Z] plugins: mock-3.12.0
[task 2024-10-29T08:00:31.976Z] collecting ... collected 1 item
[task 2024-10-29T08:00:31.976Z] 
[task 2024-10-29T08:00:31.976Z] toolkit/components/glean/tests/pytest/test_yaml_indices.py::test_yamls_sorted TEST-UNEXPECTED-FAIL
[task 2024-10-29T08:00:31.976Z] 
[task 2024-10-29T08:00:31.976Z] =================================== FAILURES ===================================
[task 2024-10-29T08:00:31.976Z] ______________________________ test_yamls_sorted _______________________________
[task 2024-10-29T08:00:31.976Z] toolkit/components/glean/tests/pytest/test_yaml_indices.py:36: in test_yamls_sorted
[task 2024-10-29T08:00:31.976Z]     assert (
[task 2024-10-29T08:00:31.976Z] E   AssertionError: gecko_metrics must be be lexicographically sorted.
[task 2024-10-29T08:00:31.976Z] E   assert ['accessible/metrics.yaml',\n 'browser/base/content/metrics.yaml',\n 'devtools/client/shared/metrics.yaml',\n 'docshell/base/metrics.yaml',\n 'dom/base/use_counter_metrics.yaml',\n 'dom/geolocation/metrics.yaml',\n 'dom/localstorage/metrics.yaml',\n 'dom/media/eme/metrics.yaml',\n 'dom/media/hls/metrics.yaml',\n 'dom/media/metrics.yaml',\n 'dom/media/webrtc/metrics.yaml',\n 'dom/metrics.yaml',\n 'dom/notification/metrics.yaml',\n 'dom/performance/metrics.yaml',\n 'dom/quota/metrics.yaml',\n 'dom/security/metrics.yaml',\n 'dom/webauthn/metrics.yaml',\n 'gfx/metrics.yaml',\n 'image/decoders/metrics.yaml',\n 'js/xpconnect/metrics.yaml',\n 'layout/base/metrics.yaml',\n 'mobile/shared/actors/metrics.yaml',\n 'mobile/shared/modules/geckoview/metrics.yaml',\n 'modules/libjar/metrics.yaml',\n 'modules/libpref/metrics.yaml',\n 'netwerk/metrics.yaml',\n 'netwerk/protocol/http/metrics.yaml',\n 'parser/html/metrics.yaml',\n 'parser/htmlparser/metrics.yaml',\n 'security/certverifier/metrics.yaml',\n 'security/ct/metrics.yaml',\n 'security/manager/ssl/metrics.yaml',\n 'services/common/metrics.yaml',\n 'services/sync/modules/metrics.yaml',\n 'toolkit/components/antitracking/bouncetrackingprotection/metrics.yaml',\n 'toolkit/components/antitracking/imageinputmetadatastripper/metrics.yaml',\n 'toolkit/components/antitracking/metrics.yaml',\n 'toolkit/components/cookiebanners/metrics.yaml',\n 'toolkit/components/downloads/metrics.yaml',\n 'toolkit/components/enterprisepolicies/metrics.yaml',\n 'toolkit/components/extensions/metrics.yaml',\n 'toolkit/components/formautofill/metrics.yaml',\n 'toolkit/components/glean/metrics.yaml',\n 'toolkit/components/messaging-system/metrics.yaml',\n 'toolkit/components/normandy/metrics.yaml',\n 'toolkit/components/passwordmgr/metrics.yaml',\n 'toolkit/components/pdfjs/metrics.yaml',\n 'toolkit/components/printing/metrics.yaml',\n 'toolkit/components/processtools/metrics.yaml',\n 'toolkit/components/reader/metrics.yaml',\n 'toolkit/components/reportbrokensite/metrics.yaml',\n 'toolkit/components/resistfingerprinting/metrics.yaml',\n 'toolkit/components/translations/metrics.yaml',\n 'toolkit/content/metrics.yaml',\n 'toolkit/content/widgets/metrics.yaml',\n 'toolkit/mozapps/extensions/metrics.yaml',\n 'toolkit/mozapps/extensions/metrics_legacy.yaml',\n 'toolkit/mozapps/handling/metrics.yaml',\n 'toolkit/profile/metrics.yaml',\n 'toolkit/xre/metrics.yaml',\n 'xpcom/metrics.yaml'] == ['accessible/metrics.yaml',\n 'browser/base/content/metrics.yaml',\n 'devtools/client/shared/metrics.yaml',\n 'docshell/base/metrics.yaml',\n 'dom/base/use_counter_metrics.yaml',\n 'dom/geolocation/metrics.yaml',\n 'dom/localstorage/metrics.yaml',\n 'dom/media/eme/metrics.yaml',\n 'dom/media/hls/metrics.yaml',\n 'dom/media/metrics.yaml',\n 'dom/media/webrtc/metrics.yaml',\n 'dom/metrics.yaml',\n 'dom/notification/metrics.yaml',\n 'dom/performance/metrics.yaml',\n 'dom/quota/metrics.yaml',\n 'dom/security/metrics.yaml',\n 'dom/webauthn/metrics.yaml',\n 'gfx/metrics.yaml',\n 'image/decoders/metrics.yaml',\n 'js/xpconnect/metrics.yaml',\n 'layout/base/metrics.yaml',\n 'mobile/shared/actors/metrics.yaml',\n 'mobile/shared/modules/geckoview/metrics.yaml',\n 'modules/libjar/metrics.yaml',\n 'modules/libpref/metrics.yaml',\n 'netwerk/metrics.yaml',\n 'netwerk/protocol/http/metrics.yaml',\n 'parser/html/metrics.yaml',\n 'parser/htmlparser/metrics.yaml',\n 'security/certverifier/metrics.yaml',\n 'security/ct/metrics.yaml',\n 'security/manager/ssl/metrics.yaml',\n 'services/common/metrics.yaml',\n 'services/sync/modules/metrics.yaml',\n 'toolkit/components/antitracking/bouncetrackingprotection/metrics.yaml',\n 'toolkit/components/antitracking/metrics.yaml',\n 'toolkit/components/antitracking/imageinputmetadatastripper/metrics.yaml',\n 'toolkit/components/cookiebanners/metrics.yaml',\n 'toolkit/components/downloads/metrics.yaml',\n 'toolkit/components/enterprisepolicies/metrics.yaml',\n 'toolkit/components/extensions/metrics.yaml',\n 'toolkit/components/formautofill/metrics.yaml',\n 'toolkit/components/glean/metrics.yaml',\n 'toolkit/components/messaging-system/metrics.yaml',\n 'toolkit/components/normandy/metrics.yaml',\n 'toolkit/components/passwordmgr/metrics.yaml',\n 'toolkit/components/pdfjs/metrics.yaml',\n 'toolkit/components/printing/metrics.yaml',\n 'toolkit/components/processtools/metrics.yaml',\n 'toolkit/components/reader/metrics.yaml',\n 'toolkit/components/reportbrokensite/metrics.yaml',\n 'toolkit/components/resistfingerprinting/metrics.yaml',\n 'toolkit/components/translations/metrics.yaml',\n 'toolkit/content/metrics.yaml',\n 'toolkit/content/widgets/metrics.yaml',\n 'toolkit/mozapps/extensions/metrics.yaml',\n 'toolkit/mozapps/extensions/metrics_legacy.yaml',\n 'toolkit/mozapps/handling/metrics.yaml',\n 'toolkit/profile/metrics.yaml',\n 'toolkit/xre/metrics.yaml',\n 'xpcom/metrics.yaml']
[task 2024-10-29T08:00:31.976Z] E     At index 35 diff: 'toolkit/components/antitracking/imageinputmetadatastripper/metrics.yaml' != 'toolkit/components/antitracking/metrics.yaml'
[task 2024-10-29T08:00:31.976Z] E     Full diff:
[task 2024-10-29T08:00:31.976Z] E       [
[task 2024-10-29T08:00:31.976Z] E        'accessible/metrics.yaml',
[task 2024-10-29T08:00:31.976Z] E        'browser/base/content/metrics.yaml',
[task 2024-10-29T08:00:31.976Z] E        'devtools/client/shared/metrics.yaml',
[task 2024-10-29T08:00:31.976Z] E        'docshell/base/metrics.yaml',
[task 2024-10-29T08:00:31.976Z] E        'dom/base/use_counter_metrics.yaml',
[task 2024-10-29T08:00:31.976Z] E        'dom/geolocation/metrics.yaml',
[task 2024-10-29T08:00:31.976Z] E        'dom/localstorage/metrics.yaml',
[task 2024-10-29T08:00:31.976Z] E        'dom/media/eme/metrics.yaml',
[task 2024-10-29T08:00:31.977Z] E        'dom/media/hls/metrics.yaml',
[task 2024-10-29T08:00:31.977Z] E        'dom/media/metrics.yaml',
[task 2024-10-29T08:00:31.977Z] E        'dom/media/webrtc/metrics.yaml',
[task 2024-10-29T08:00:31.977Z] E        'dom/metrics.yaml',
[task 2024-10-29T08:00:31.977Z] E        'dom/notification/metrics.yaml',
[task 2024-10-29T08:00:31.977Z] E        'dom/performance/metrics.yaml',
[task 2024-10-29T08:00:31.977Z] E        'dom/quota/metrics.yaml',
[task 2024-10-29T08:00:31.977Z] E        'dom/security/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'dom/webauthn/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'gfx/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'image/decoders/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'js/xpconnect/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'layout/base/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'mobile/shared/actors/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'mobile/shared/modules/geckoview/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'modules/libjar/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'modules/libpref/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'netwerk/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'netwerk/protocol/http/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'parser/html/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'parser/htmlparser/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'security/certverifier/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'security/ct/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'security/manager/ssl/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'services/common/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'services/sync/modules/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/antitracking/bouncetrackingprotection/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E     +  'toolkit/components/antitracking/imageinputmetadatastripper/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/antitracking/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E     -  'toolkit/components/antitracking/imageinputmetadatastripper/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/cookiebanners/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/downloads/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/enterprisepolicies/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/extensions/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/formautofill/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/glean/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/messaging-system/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/normandy/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/passwordmgr/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/pdfjs/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/printing/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/processtools/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/reader/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/reportbrokensite/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/resistfingerprinting/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/components/translations/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/content/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/content/widgets/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/mozapps/extensions/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/mozapps/extensions/metrics_legacy.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/mozapps/handling/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/profile/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'toolkit/xre/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E        'xpcom/metrics.yaml',
[task 2024-10-29T08:00:31.985Z] E       ]
[task 2024-10-29T08:00:31.985Z] ============================== 1 failed in 0.04s ===============================
[task 2024-10-29T08:00:31.985Z] 
[task 2024-10-29T08:00:31.985Z] 
[task 2024-10-29T08:00:31.985Z] Tests Completed: 100%|██████████| 7/7 [00:10<00:00,  1.54s/Test]Return code from mach python-test: 1
[task 2024-10-29T08:00:32.017Z] 
[taskcluster 2024-10-29 08:00:32.470Z] === Task Finished ===
[taskcluster 2024-10-29 08:00:32.470Z] Unsuccessful task run with exit code: 1 completed in 224.034 seconds

————————————————————————————
Backed out for causing mochitest failures @ test_webkitdirectory.html

Push with failures
Failure Log
Failure snippet:

[task 2024-10-29T08:46:00.141Z] 08:46:00     INFO - TEST-START | dom/filesystem/tests/test_webkitdirectory.html
[task 2024-10-29T08:46:00.619Z] 08:46:00     INFO - GECKO(2507) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpu62nodew.mozrunner/runtests_leaks_tab_pid2890.log
[task 2024-10-29T08:46:00.627Z] 08:46:00     INFO - GECKO(2507) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpu62nodew.mozrunner/runtests_leaks_tab_pid2896.log
[task 2024-10-29T08:46:00.628Z] 08:46:00     INFO - GECKO(2507) | ### XPCOM_MEM_BLOAT_LOG defined -- logging bloat/leaks to /tmp/tmpu62nodew.mozrunner/runtests_leaks_tab_pid2900.log
[task 2024-10-29T08:51:28.612Z] 08:51:28     INFO - TEST-INFO | started process screentopng
[task 2024-10-29T08:51:28.745Z] 08:51:28     INFO - TEST-INFO | screentopng: exit 0
[task 2024-10-29T08:51:28.745Z] 08:51:28     INFO - Buffered messages logged at 08:46:00
[task 2024-10-29T08:51:28.746Z] 08:51:28     INFO - TEST-PASS | dom/filesystem/tests/test_webkitdirectory.html | 0 == 0 
[task 2024-10-29T08:51:28.746Z] 08:51:28     INFO - Buffered messages finished
[task 2024-10-29T08:51:28.746Z] 08:51:28     INFO - TEST-UNEXPECTED-FAIL | dom/filesystem/tests/test_webkitdirectory.html | Test timed out. - 
[task 2024-10-29T08:51:29.616Z] 08:51:29     INFO - GECKO(2507) | MEMORY STAT | vsize 2538MB | residentFast 99MB | heapAllocated 6MB
[task 2024-10-29T08:51:29.666Z] 08:51:29     INFO - TEST-OK | dom/filesystem/tests/test_webkitdirectory.html | took 329524ms
[task 2024-10-29T08:51:29.696Z] 08:51:29     INFO - TEST-START | dom/filesystem/tests/test_worker_basic.html

Flags: needinfo?(lschwarz)

Phabricator Automation

Updated

•

1 month ago

Attachment #9432595 - Attachment is obsolete: true

Leander Schwarz

Assignee

Updated

•

1 month ago

Flags: needinfo?(lschwarz)

Pulsebot

Comment 6

•

1 month ago

Pushed by lschwarz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7b781e92d67c Add file and input type telemetry for EXIF metadata stripper project. r=bvandersloot,anti-tracking-reviewers

Cristian Tuns

Comment 7

•

29 days ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/7b781e92d67c

Status: ASSIGNED → RESOLVED

Closed: 29 days ago

status-firefox134: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 134 Branch

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Add telemetry for uploads file metadata telemetry

Categories

(Core :: Privacy: Anti-Tracking, task)

Tracking

()

People

(Reporter: leander.schwarz, Assigned: leander.schwarz)

References

(Blocks 1 open bug)

Details

Crash Data

Security

(public)

User Story

Attachments

(1 file, 2 obsolete files)

Description

Comment 1

Comment 2

Comment 3

Updated

Comment 4

Comment 5

Updated

Updated

Comment 6

Comment 7

Attachment

General

Description

File Name

Content Type