Closed Bug 1899161 Opened 1 month ago Closed 24 days ago

[wpt-sync] Sync PR 46498 - Use ComputeDegrees with conversion data for rotate*() transforms

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox128 fixed)

Status:
RESOLVED FIXED
Milestone:
128 Branch
Tracking Flags:
Tracking Status
firefox128 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 46498 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46498
Details from upstream follow.

Daniil Sakhapov <sakhapov@chromium.org> wrote:

Use ComputeDegrees with conversion data for rotate*() transforms

Bug: 40946458
Change-Id: I1fbdf113ee4d4f7d32d2c580108e967257ea3150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5569744
Reviewed-by: Anders Hartvoll Ruud \<andruud@chromium.org>
Commit-Queue: Daniil Sakhapov \<sakhapov@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1306413}

PR 46498 applied with additional changes from upstream: ba29c08e812f19fc038c5fcba6a8789b175be887, a16303f67e64a42e9c68d534ed624775088355fb, 5addc771eccd8aa0e5860b5eb99ceba0dfafdd38
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
FAIL : 9

Chrome

CRASH: 1

Safari

OK : 1
FAIL : 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-transforms/transform-with-sign-function.html [wpt.fyi]
    • skew(calc(sign(1em - 1px) * 2deg), calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to skew(2deg, 2deg): FAIL (Safari: FAIL)
    • skewX(calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to skewX(2deg): FAIL (Safari: FAIL)
    • skewY(calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to skewY(2deg): FAIL (Safari: FAIL)
    • matrix(calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2)) should be used-value-equivalent to matrix(2, 2, 2, 2, 2, 2): FAIL (Safari: FAIL)
    • matrix3d(calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2),calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2)) should be used-value-equivalent to matrix3d(2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2): FAIL (Safari: FAIL)
    • rotate(calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to rotate(2deg): FAIL (Safari: FAIL)
    • rotateX(calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to rotateX(2deg): FAIL (Safari: FAIL)
    • rotateY(calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to rotateY(2deg): FAIL (Safari: FAIL)
    • rotateZ(calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to rotateZ(2deg): FAIL (Safari: FAIL)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2a0276377888
[wpt PR 46498] - Use ComputeDegrees with conversion data for rotate*() transforms, a=testonly
https://hg.mozilla.org/integration/autoland/rev/c5a3f1c28beb
[wpt PR 46498] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2a0276377888
https://hg.mozilla.org/mozilla-central/rev/c5a3f1c28beb

Status: NEW → RESOLVED
Closed: 24 days ago
status-firefox128: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.