Closed
Bug 1899189
Opened 1 year ago
Closed 1 year ago
missing frames when DynamicResampler switches from resampling to copying
Categories
(Core :: WebRTC: Audio/Video, defect)
Core
WebRTC: Audio/Video
Tracking
()
RESOLVED
FIXED
128 Branch
| Tracking | Status | |
|---|---|---|
| firefox128 | --- | fixed |
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(2 files)
DynamicResampler uses speex_resampler_skip_zeros() to skip the extra frames when switching from copying to resampling, but does not fill in the missing frames when switching from resampling to copying.
|
Assignee | |
Comment 1•1 year ago
|
||
|
|
Assignee | |
Comment 2•1 year ago
|
||
The factor of 3 snuck in undocumented in
https://hg.mozilla.org/mozilla-central/rev/3030d1b69789fd52d41f2fef068d09323032c236#l2.149
I don't know why incorrect signs have been tolerated since introduction
https://hg.mozilla.org/mozilla-central/rev/cf5c2e6845361d60c0a974d188fd795732233d02#l1.131
Depends on D211817
Pushed by ktomlinson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dce7fdb9e30d
Fill in missing frames when switching from resampling to copying r=padenot
Pushed by ktomlinson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0830783105f7
Tighten AudioVerifier discontinuity test r=padenot
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dce7fdb9e30d
https://hg.mozilla.org/mozilla-central/rev/0830783105f7
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox128:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•