1899345 - Replace ScrollContainerFrame::OverflowState with mozilla::PhysicalAxes

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Per emilio's review comment in https://phabricator.services.mozilla.com/D211499#7267763, we could improve OverflowState by declaring it as uint8_t.

After taking a closer look at the enum, it is just a return value of a non-public method GetOverflowState, and it is public just because we implement MOZ_MAKE_ENUM_CLASS_BITWISE_OPERATORS on it. I think this enum is equivalent to PhysicalAxes per implementation of GetOverflowState(). I'll upload patches later to improve this.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1899345 Part 1 - Convert PhysicalAxes to an EnumSet<PhysicalAxis>. r?#layout

This also makes PhysicalAxis::{Horizontal,Vertical} more useful when we
previous needed PhysicalAxes::{Horizontal,Vertical}.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1899345 Part 2 - Rename GetOverflowState() and use PhysicalAxes as its return type. r?#layout

OverflowState is equivalent to PhysicalAxes. We really don't need a separate
type.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f66d112b450
Part 1 - Convert PhysicalAxes to an EnumSet<PhysicalAxis>. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/ccb2ccbef46e
Part 2 - Rename GetOverflowState() and use PhysicalAxes as its return type. r=layout-reviewers,emilio

Comment 4

[Serban Stanca [:SerbanS]]

Backed out for causing android build bustages in ScrollContainerFrame.cpp.

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/layout/generic/ScrollContainerFrame.cpp:6231:9: error: use of undeclared identifier 'GetOverflowState'; did you mean 'GetOverflowFrames'?

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Oops, there is a GetOverflowState() call in #if defined(MOZ_WIDGET_ANDROID) that I didn't convert https://searchfox.org/mozilla-central/rev/f60bb10a5fe6936f9e9f9e8a90d52c18a0ffd818/layout/generic/ScrollContainerFrame.cpp#6230

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/01a540f73690
Part 1 - Convert PhysicalAxes to an EnumSet<PhysicalAxis>. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/b96c165e9ab4
Part 2 - Rename GetOverflowState() and use PhysicalAxes as its return type. r=layout-reviewers,emilio

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for conflicting with backout of Bug 1896516:
https://hg.mozilla.org/mozilla-central/rev/c6b3fea6d3d424f90af3d28ff1777dc78f775cbf

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/23c00f7ab582
Part 1 - Convert PhysicalAxes to an EnumSet<PhysicalAxis>. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/ce424186fe41
Part 2 - Rename GetOverflowState() and use PhysicalAxes as its return type. r=layout-reviewers,emilio

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/23c00f7ab582
https://hg.mozilla.org/mozilla-central/rev/ce424186fe41