1899411 - Update segmenter to ICU4X 1.5

Status: RESOLVED FIXED

(Core :: Internationalization, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

ICU4X 1.5 has been released https://github.com/unicode-org/icu4x/releases/tag/icu%401.5.0. We can import it to get a proper fix for bug 1880362, https://github.com/unicode-org/icu4x/issues/4446, and maybe other bugs.

Comment 1

[Makoto Kato [:m_kato]]

css/css-pseudo/first-letter-hi-001.html is incompatible with ICU4X 1.5. I guess that Unicode 15.1 has some rules for Indic language.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1899411 - Part 1. Update shell script and patch files for ICU4X 1.5. r=TYLin

Update script and patches for ICU4X 1.5

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1899411 - Part 2. Update icu_capi and icu_segmenter_data to 1.5. r=TYLin!

Run sh update-icu4x.sh https://github.com/unicode-org/icu4x.git icu@1.5.0 45.0.0 release-75-1 1.5.0.

Comment 4

[Makoto Kato [:m_kato]]

Attachment: Bug 1899411 - Part 3. Update ICU4X to 1.5. r=#supply-chain-reviewers!,#platform-i18n-reviewers!,#firefox-build-system-reviewers!

Test files for icu_segmenter is too large, so I add build system reviewers as reviewers.

Comment 5

[Makoto Kato [:m_kato]]

Attachment: Bug 1899411 - Part 4. Build fix for ICU4X 1.5. r=#spidermonkey-reviewers!,TYLin!

icu_capi 1.5 has small changes for 8-bit char type.

Comment 6

[Makoto Kato [:m_kato]]

Attachment: Bug 1899411 - Part 5. first-letter-hi-001.html should consider Unicode 15.1. r=jfkthame!

After applying ICU4X 1.5, this test are failure. Grapheme cluster in ICU4X 1.5
uses Unicode 15.1, so some Indic language rules are different [*1].

• https://unicode.org/reports/tr29/#GB9c

Comment 7

[Makoto Kato [:m_kato]]

Attachment: Bug 1899411 - Part 6. Adjust test results after upgrading ICU4X to 1.5. r=jfkthame!,#spidermonkey-reviewers!

Comment 8

[André Bargull [:anba]]

I'm still waiting for an r+ from platform-i18n-reviewers for https://phabricator.services.mozilla.com/D211762 (bug 1899177), but I guess at this point it makes more sense to first land your changes and after that bug 1899177, right?

Comment 9

[Makoto Kato [:m_kato]]

Yes, since ICU4X 1.5 is released, I have to update all crates to 1.5. This release has some bug fix for Intl.Segmenter too.

Of course, If you want to land bug 1899177 soon, I can wait for it.

Comment 10

[André Bargull [:anba]]

I'm happy to wait landing bug 1899177, assuming the update to 1.5 lands in the next two weeks or so. (If you need more time for the update, I'll probably try to land bug 1899177 first.)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43093acb50a2
Part 1. Update shell script and patch files for ICU4X 1.5. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/0f6e56cf3c7a
Part 2. Update icu_capi and icu_segmenter_data to 1.5. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/3aaeee2d7204
Part 3. Update ICU4X to 1.5. r=supply-chain-reviewers,platform-i18n-reviewers,firefox-build-system-reviewers,webdriver-reviewers,whimboo,glandium
https://hg.mozilla.org/integration/autoland/rev/3dc65d6b8662
Part 4. Build fix for ICU4X 1.5. r=TYLin,spidermonkey-reviewers,anba
https://hg.mozilla.org/integration/autoland/rev/bd64aa85c08c
Part 5. first-letter-hi-001.html should consider Unicode 15.1. r=jfkthame
https://hg.mozilla.org/integration/autoland/rev/12d5ea126a22
Part 6. Adjust test results after upgrading ICU4X to 1.5. r=jfkthame,spidermonkey-reviewers,anba

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46778 for changes under testing/web-platform/tests

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/43093acb50a2
https://hg.mozilla.org/mozilla-central/rev/0f6e56cf3c7a
https://hg.mozilla.org/mozilla-central/rev/3aaeee2d7204
https://hg.mozilla.org/mozilla-central/rev/3dc65d6b8662
https://hg.mozilla.org/mozilla-central/rev/bd64aa85c08c
https://hg.mozilla.org/mozilla-central/rev/12d5ea126a22

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot