1899524 - Use nsACString types for the crash annotations' generated code

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, task)

Description

[Gabriele Svelto [:gsvelto]]

The code generated from CrashAnnotations.h.in used bare const char* when dealing with string because it was included in the crash reporter client where XUL strings could not be used. With the old crash reporter client gone we can now use nsACString instead which simplifies things and opens up using this code with non-NUL-terminated strings.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1899524 - Use XUL strings in the code generated to deal with crash annotations r=afranchuk

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52dc5cfa5439
Use XUL strings in the code generated to deal with crash annotations r=afranchuk

Comment 3

[Cristian Tuns]

Backed out for causing build bustages with rust_minidump_writer_linux

• Backout link
• Push with failures
• Failure Log
• Failure line: error[E0658]: use of unstable library feature 'offset_of'
  error: could not compile rust_minidump_writer_linux (lib) due to 4 previous errors
  gmake[4]: *** [/builds/worker/checkouts/gecko/config/makefiles/rust.mk:498: force-cargo-library-build] Error 101

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f8a80c4ad32
Use XUL strings in the code generated to deal with crash annotations r=afranchuk

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/9f8a80c4ad32