1899573 - Add search engine settings migration handling for Wikipedia engines that are to be renamed

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[Mark Banner (:standard8)]

We want to bring some of the titles for the Wikipedia search engines up to date so that they match the site and the site’s OpenSearch definition. This will unify prevent us showing the “Add new engine” option on the address and search bars. It will also unify the names with mobile.

Since Firefox 108 we have the settings indexed by the search engine identifier. However for upgrades from before then, we fallback to matching the name of the search engine. Therefore I think we should add handling to the existing migration to ensure those users can still migrate properly.

Once the migration has shipped, then we can do the update of search engine names in search-config-v2 which will be filed as a separate ticket.

The proposed renames are:

• wikipedia-hy “Wikipedia (hy)” → “Վիքիպեդիա (hy)”
• wikipedia-kn “Wikipedia (kn)” → “ವಿಕಿಪೀಡಿಯ (kn)”
• wikipedia-lv “Vikipēdija” → “Vikipēdija (lv)”
• wikipedia-no “Wikipedia (no)” → “Wikipedia (nb)”
• wikipedia-el “Wikipedia (el)” → “Βικιπαίδεια (el)”
• wikipedia-lt “Wikipedia (lt)” → “Vikipedija (lt)”
• wikipedia-my “Wikipedia (my)” → “ဝီကီပီးဒီးယား (my)”
• wikipedia-pa “Wikipedia (pa)” → “ਵਿਕੀਪੀਡੀਆ (pa)”
• wikipedia-pt “Wikipedia (pt)” → “Wikipédia (pt)”
• wikipedia-si “Wikipedia (si)” → “විකිපීඩියා (si)”
• wikipedia-tr “Wikipedia (tr)” → “Vikipedi (tr)”

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1899573 - Add search engine settings migration handling for Wikipedia engines that are to be renamed. r?#search-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72fb8d20757f
Add search engine settings migration handling for Wikipedia engines that are to be renamed. r=search-reviewers,mcheang

Comment 3

[Mark Banner (:standard8)]

For QA: The only way to really test this is with testing an upgrade to a build that has both the migration handling from this bug, and the remote settings changes in bug 1899574.

Without that, we would fail to trigger the new code. We can't release the remote settings changes until after the migration handling patch from this bug is out on release. Therefore, I am creating some try builds with the patch and the remote settings changes in.

Try builds: https://treeherder.mozilla.org/jobs?repo=try&revision=b720cd4d523356c8fed6754d2bc0c978f2e62cb3

To test them:

1. Download a Firefox 107 build for one of the affected locales/wikipedias.
2. On the Wikipedia search engine do one of:
   a. Set up an alias
   b. Hide it
   c. Set it as default
3. "Upgrade" to the build from try server.

The settings in step 2 should be kept.

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/72fb8d20757f

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1899573 - Add search engine settings migration handling for Wikipedia engines that are to be renamed. r?#search-reviewers!

Original Revision: https://phabricator.services.mozilla.com/D212200

Comment 6

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: Users may loose settings when we rename some of the Wikipedia engines in future
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Note see comment 3 - this cannot be directly tested in a build, but needs an additional try build.
• Risk associated with taking this patch: Low
• Explanation of risk level: Affects only a few search engines.
• String changes made/needed: None
• Is Android affected?: no

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/1c83b901d9c9

Comment 8

[Cristian Baica [:cbaica], Release Desktop QA]

QA is currently working on this. Unfortunately some issues were discovered while trying to test this:

• no beta builds earlier than 115 are available in the build directory archive. for e.g. here are the contents for 107.0b5 build folder.
• no localized try builds available, which ads considerable more steps to the verification and makes certain user changes unable to be verified (like default search engine).
• using LiveLanguageSwitch as a workaround makes the verification of the new search engine name unreliable

Comment 9

[Cristian Baica [:cbaica], Release Desktop QA]

QA has finished testing the search engine rename for certain wikipedia locales. The results can be viewed here.

There are a few notes that need to be specified before moving forward with this:

• testing was only done using nightly 107.0a1 builds as there are no beta builds earlier than version 115 in the candidates archive
• testing was done using Live Language Switching as there were no localized try-builds available. This means that the tranzition for the upgrade was done by passing through the 'en-US' locale
• because only an 'en-US' upgrade is available, the case where Wikipedia is set as default search engine and kept as default search engine was excluded from testing scope

Comment 10

[Mark Banner (:standard8)]

(In reply to Cristian Baica [:cbaica], Release Desktop QA from comment #9)

• because only an 'en-US' upgrade is available, the case where Wikipedia is set as default search engine and kept as default search engine was excluded from testing scope

There's a very small amount of users on versions prior to 107 and where the engine is Wikipedia, due to the complexity of managing the search engine upgrade to keep the default engine in this scenario, we decided it wasn't worth it in this instance (and some of the users are on older versions where they're unlikely to upgrade).

Comment 11

[Adrian Florinescu [:aflorinescu] [PTO until Aug 26]]]

As discussed yesterday, we did a 107.0a1 hy-am update to 128.0a1 (try) on both win10 and mac 11 with no issues. For the kn locale, we couldn't find a build in the Nightly107 repository to update from, so we dropped that.
The case from comment 9 where the wikipedia default is not kept after the update is also reproducible with the above setup (wishful thinking checked!).