1899597 - Test-case in bug 1480477 regressed even more with :has().

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1899597 - Add a perf test for DOM removal with positional pseudo-classes. r=dshin,#style

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1899597 - Avoid double walk over siblings in style invalidation. r=dshin,#style

This fixes a regression with :has() on the test-case of bug 1480477 (but
we should still aim to make that faster).

While at it, avoid synchronization in some really hot paths, and add
tests.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c832d9544d2a
Avoid double walk over siblings in style invalidation. r=dshin

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c832d9544d2a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d8ffedb457a
Add a perf test for DOM removal with positional pseudo-classes. r=perftest-reviewers,sparky

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/6d8ffedb457a

Comment 7

[Andrej (:aglavic)]

(In reply to Pulsebot from comment #5)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d8ffedb457a
Add a perf test for DOM removal with positional pseudo-classes.
r=perftest-reviewers,sparky

Perfherder has detected a talos performance change from push c832d9544d2aa8b2edd14c2a490c03fe34c4bbf4.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
6%	perf_reftest_singletons remove-front-has-pseudo.html	windows10-64-shippable-qr	e10s fission stylo webrender	35.65 -> 33.48

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 653

For more information on performance sheriffing please see our FAQ.