1899714 - You are not permitted to print this document message is no longer displayed when printing sensitive data

Status: VERIFIED FIXED

(Firefox :: Data Loss Prevention, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: dlp_3.gif

Found in

• 128.0a1 (2024-05-29)

Affected versions

• 128.0a1 (2024-05-29)

Tested platforms

• Affected platforms: Windows 10x64, Windows 11x64
• Unaffected platforms: macOS, Ubuntu

Preconditions

• Download the DLP test assets from https://drive.google.com/file/d/1yjqVRuxdKV3WnO7D2wzMgDXBuYBxUgVw/view
• Create a distribution folder inside the Firefox folder and paste the policies-1.json to it and then rename it to policies.json
• run the DLP agent in CMD using: .\content_analysis_sdk_agent.exe --user --toblock=.\d{3}-?\d{2}-?\d{4}. --towarn=.warn. --delays=10

Steps to reproduce

1. Navigate to https://en.wikipedia.org/wiki/123456789
2. Print the page.

Expected result

• After 10 seconds the dialog You're not permitted to print this document is displayed.

Actual result

• The print preview disappears and nothing happens.

Regression range

• This most likely started after bug 1898718.

Additional notes

• Attached a screen recording.
• The document is not printed as expected.
• The Notification that the DLP agent is reviewing data is displayed.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:gstoll, since you are the author of the regressor, bug 1898718, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Greg Stoll :gstoll]

Wow, bug 1898718 did regress this! That's surprising. Gonna take a look.

Comment 3

[Greg Stoll :gstoll]

I think the problem is that the call to print is throwing an NS_ERROR_CONTENT_BLOCKED error, which gets caught and then the print preview window gets closed right away, which also closes the "blocked" dialog. This happened to work in the past because the dialog was being shown synchronously, which wouldn't let the window close until it went away I guess?

Comment 4

[Greg Stoll :gstoll]

Attachment: Bug 1899714 - make DLP block dialog show up again for print preview window r=#dlp-reviewers!

I verified that quitting while the synchronous version of the dialog is active doesn't hang, so we're not re-regressing bug 1898718.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/324e0a8e5a27
make DLP block dialog show up again for print preview window r=dlp-reviewers,handyman

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/324e0a8e5a27

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 128.0a1 (20240605093026) on Windows 10x64 and Windows 11. The DLP block dialog is successfully displayed after following steps from comment 0 and no shutdown hang can be seen when closing Firefox while the DLP block dialog is active. However, this might have introduced a regression, but we are unsure, see bug 1900798 for more details.

Comment 8

[Andrej (:aglavic)]

Perfherder has detected a talos performance change from push 3b98afd40620067845b46a4d7d5c05c010c1b4bc.

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
16%	about_preferences_basic	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	127.52 -> 107.17
8%	about_preferences_basic	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	171.36 -> 157.09

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 633

For more information on performance sheriffing please see our FAQ.