1899717 - Calls to @@dispose at the time of disposal should not be observable by user code

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Debadree Chatterjee]

The following code is a bug

let called = 0;
{
  using d = {
    get [Symbol.dispose]() {
      called++;
      return () => {};
    }
  };
}

Comment 1

[Tooru Fujisawa [:arai]]

Given the code is not enabled anywhere, making it a task.

Comment 2

[Debadree Chatterjee]

Attachment: Bug 1899717 - Make calls to @@dispose during disposal unobserveable to the user. r?arai!

This patch brings all the error handling and checks surrounding AddDisposable
into the implementation of the AddDisposable bytecode and also updates the
implementation to use DisposableResource Records.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5d4dd8af6a0
Make calls to @@dispose during disposal unobserveable to the user. r=arai

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d5d4dd8af6a0