1899824 - Remove code for `seekToNextFrame`

Status: NEW

(Core :: Audio/Video: Playback, task)

Description

[Paul Adenot (:padenot)]

Following up bug 1336404, we can remove the supporting code, and I think this will lead to simplification of the seeking code (that is already quite complex).

Internal consumer remaining:

https://searchfox.org/mozilla-central/source/dom/media/test/crashtests/1450845.html is a test for SeekToNextFrame itself
https://searchfox.org/mozilla-central/source/dom/media/test/reftest/generateREF.html is a utility for gfx to generate some reftests. We (should) port this to Web Codecs, but maybe it's not needed. alwu, an opinion vs. using another tool or manually doing it?
https://searchfox.org/mozilla-central/source/dom/media/test/reftest/short.mp4.lastframe.html, we can just seek normally, this ought to work well with my rework of TimeUnit.
https://searchfox.org/mozilla-central/source/dom/media/test/test_background_video_resume_after_end_show_last_frame.html same
https://searchfox.org/mozilla-central/source/dom/media/test/test_mediarecorder_record_changing_video_resolution.html for this we can just wait for the video to be played back. pehrsons, is that right?
https://searchfox.org/mozilla-central/source/dom/media/test/test_seekToNextFrame.html we can remove this because it tests the feature itself

Comment 1

[Andreas Pehrson [:pehrsons]]

(In reply to Paul Adenot (:padenot) from comment #0)

https://searchfox.org/mozilla-central/source/dom/media/test/test_mediarecorder_record_changing_video_resolution.html for this we can just wait for the video to be played back. pehrsons, is that right?

That's right. I think we had some idea to use seekToNextFrame originally because it lets us be certain about what frame we get when we draw the video element to a canvas, so we can also check the color. Not sure why we didn't do that in the end. Ideally we should do this with WebCodecs.

Comment 2

[Alastor Wu [:alwu]]

(In reply to Paul Adenot (:padenot) from comment #0)

https://searchfox.org/mozilla-central/source/dom/media/test/reftest/generateREF.html is a utility for gfx to generate some reftests. We (should) port this to Web Codecs, but maybe it's not needed. alwu, an opinion vs. using another tool or manually doing it?

I think it still has a benefit to keep one our internal tool to generate a reference image, if we use other tools, the image displayed might not be exactly same as what Firefox would display, eg. differences in color. That will be great if we can rewrite it by using web codec API.