1899853 - `errorCode` is never going to be "interrupted" in aboutNetError.mjs

Status: RESOLVED FIXED

(Firefox :: Security, task, P3)

Description

[Dana Keeler (she/her) [:keeler]]

initPage() in toolkit/content/aboutNetError.mjs has a "interrupted" case for errorCode, but that's not a valid value for errorCode. I believe this comes from 0cf57171638c in bug 1561443.

This is very minor, since it's just dead code, but it confused me for a bit, so maybe it would be nice to take out.

Comment 1

[Manuel Bucher [:manuel]]

Going through history it seems like the "interrupted" case origins from 00b8a2d2825f in Bug 1252068. @dana did something change in Bug 1561443 that makes the case not appear anymore? I find the comment // This happens with subresources that are above the max tls not very helpful so this bug is either about updating the comment or removing the case.

Comment 2

[Dana Keeler (she/her) [:keeler]]

My understanding is that before bug 1561443, the implementation searched through the text of a section of the error page itself. At that point, the text "interrupted" could appear and thus was a valid case. As part of the changes in that bug, though, that code was changed to match against the error name itself. The error name will never be "interrupted", so that case will never match now.

Comment 3

[Manuel Bucher [:manuel]]

Ah that makes sense and matches to the code when looking at the changeset. Removing the line case "interrupted" could be done as part as a good-first-bug.

Comment 4

[Liam DeBeasi]

Hey there,

I am interested in submitting a patch for this. Sounds like the work here is just to remove the case "interrupted" line as noted in https://bugzilla.mozilla.org/show_bug.cgi?id=1899853#c3?

Comment 5

[Manuel Bucher [:manuel]]

Hi, yes. That should be it. Nothing more required.

Comment 6

[Liam DeBeasi]

Attachment: Bug 1899853 - Remove unused interrupted case r=manuel

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/727e0be84ce8
Remove unused interrupted case r=manuel

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/727e0be84ce8