1899872 - Make js::SliceBudget a proper public API

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P1)

Description

[Steve Fink [:sfink] [:s:]]

js::SliceBudget is used by functions in the JS:: namespace, so really ought to be in that namespace itself. It also has some cryptic bool parameters that should probably be enum-ified.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1899872 - Move SliceBudget (and {Work,Time}Budget) from js:: namespace to JS::

Comment 2

[Steve Fink [:sfink] [:s:]]

Attachment: Bug 1899872 - Create IsIdle and IsExtended enums for SliceBudget

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2753b7c1309f
Move SliceBudget (and {Work,Time}Budget) from js:: namespace to JS:: r=jonco,mccr8

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out changeset 2753b7c1309f (Bug 1899872) for causing build bustages in testSliceBudget.cpp CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=d48tqan1RTGbtQhRgGGxyQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=2753b7c1309f4e2f77725c85e72c5fdee213f7a2

Logs: https://treeherder.mozilla.org/logviewer?job_id=462127558&repo=autoland&lineNumber=9409
https://treeherder.mozilla.org/logviewer?job_id=462127565&repo=autoland&lineNumber=11628

Backout: https://hg.mozilla.org/integration/autoland/rev/006cfbb33297482b9327ed3e6e0c920466218b97

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e38543d56e9b
Move SliceBudget (and {Work,Time}Budget) from js:: namespace to JS:: r=jonco,mccr8

Comment 6

[pstanciu]

Backed out for causing build bustages

• Backout link
• Push with failures
• Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e043eb2d9b6d
Move SliceBudget (and {Work,Time}Budget) from js:: namespace to JS:: r=jonco,mccr8

Comment 8

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e043eb2d9b6d