1899894 - Remove debug statements that require customized #define

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

See the patch for details.

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1899894 - Remove debug statements that require customized #define. r?#layout

The debug statements all require customized #define to enable. I don't feel it
is useful to leave code that is not compiled in the default debug build.

Comment 2

[Timothy Nikkel (:tnikkel)]

(In reply to Ting-Yu Lin [:TYLin] (PDT, UTC-7) from comment #1)

The debug statements all require customized #define to enable. I don't feel it
is useful to leave code that is not compiled in the default debug build.

While I don't have any objection to this patch, in general I think that it can be quite useful to have code like this.

Two examples that I use

https://searchfox.org/mozilla-central/rev/fc76676f61ee37b4c5420649cad6677164a29405/gfx/layers/wr/WebRenderCommandBuilder.cpp#51
https://searchfox.org/mozilla-central/rev/fc76676f61ee37b4c5420649cad6677164a29405/layout/painting/RetainedDisplayListBuilder.cpp#867

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

I totally agree logging is useful, and I use FLEX_LOG whenever I investigate flexbox bugs.

I'm just curious as to why GP and CRR_LOG require a customized build to enable rather than being modernized as MOZ_LOG that can be turned on easily via flipping a pref.

Comment 4

[Timothy Nikkel (:tnikkel)]

They produce a lot of output.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6150d2dc57c4
Remove debug statements that require customized #define. r=layout-reviewers,emilio

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/6150d2dc57c4