1900001 - GCRuntime::markGrayRoots has unused template parameter

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P1)

Description

[Jon Coppeard (:jonco)]

While investigating bug 1896973 I noticed that the markGrayRoots method takes a zone iterator as a template parameter to tell it which zones to mark in, but it doesn't use it. Nowadays we use the zone state to control which zones have their gray roots marked.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1900001 - Remove unused template parameter from GCRuntime::markGrayRoots and add assertions r?sfink

This removes the unused template parameter and adds assertions that the right
zones are getting marked.

While doing this I found some other inconsistencies that interferred with
adding these assertions, which I straightened out as well.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eb7c8d6e6e73
Remove unused template parameter from GCRuntime::markGrayRoots and add assertions r=sfink

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/eb7c8d6e6e73