1900013 - DoH UI: mode3 warning page is too alarming when domain can't be found

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P2)

Description

[Valentin Gosu [:valentin]]

The UI shows a page similar to the certificate error page, which is a bit too alarming for a simple domain not found error in mode3.
We should instead make the page keep its existing domain not found layout, and add some of the information to the bottom - with less alarming icons.

Comment 1

[Simon Friedberger [:simonf]]

We have the same problem when there is no connection. I can't seem to find the bug for that at the moment. It's probably worth considering the different failure modes for the DoH connection so we don't end up fixing lots of individual cases.

Comment 2

[Valentin Gosu [:valentin]]

Attachment: Bug 1900013 - Remove native fallback warning from error page r=#necko

Comment 3

[Valentin Gosu [:valentin]]

Attachment: Bug 1900013 - Remove TRR fallback warning code from DNS code r=#necko,acreskey

Comment 4

[Valentin Gosu [:valentin]]

Attachment: Bug 1900013 - Make the TRR only domain not found error page less scary r=#necko

This page was looking similar to the certificate error page,
but this scenario is much more common and much less dangerous
than accepting an untrusted certificate.

This updates the page to look a bit more similar to the regular
domain not found error page.

Comment 5

[Valentin Gosu [:valentin]]

Attachment: Bug 1900013 - Remove DoH fallback warning prefs from privacy settings UI r=Gijs

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de3d59d8efe4
Remove native fallback warning from error page r=necko-reviewers,frontend-codestyle-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/79b337720f4b
Remove TRR fallback warning code from DNS code r=acreskey,necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/33c702c1b76d
Make the TRR only domain not found error page less scary r=necko-reviewers,kershaw
https://hg.mozilla.org/integration/autoland/rev/11526ec22f05
Remove DoH fallback warning prefs from privacy settings UI r=settings-reviewers,mconley

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/de3d59d8efe4
https://hg.mozilla.org/mozilla-central/rev/79b337720f4b
https://hg.mozilla.org/mozilla-central/rev/33c702c1b76d
https://hg.mozilla.org/mozilla-central/rev/11526ec22f05