1900037 - Disable broken vibration APIs

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

Currently our navigator.vibrate() and Notification.vibrate is being fully ignored, while we are still exposing the API. This is bad for feature detection and we should not expose non-working API.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1900037 - Disable vibration APIs r=#webidl

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Chrome use counter of navigator.vibrate() shows somewhere between 0.06 and 0.08%: https://chromestatus.com/metrics/feature/timeline/popularity/850

Quick check on the sampled list of most popular websites shows feature detection:

• navigator.vibrate && navigator.vibrate()
• (_18 = 'vibrate' in navigator && navigator.vibrate);

•   navigator.vibrate = navigator.vibrate ||
    navigator.webkitVibrate ||
    navigator.mozVibrate ||
    navigator.msVibrate;
    if (navigator.vibrate) {
      navigator.vibrate([500])
    }
  

•                     (
                        navigator.vibrate ? navigator.vibrate(500) : navigator.webkitVibrate &&
                        navigator.webkitVibrate(500)
                      );
  

GitHub code search also shows frequent feature detection: https://github.com/search?q=navigator.vibrate+language%3AJavaScript&type=code&l=JavaScript

Comment 3

[marcos]

FWIW, it was removed from WebKit on 2017-05-05:
https://bugs.webkit.org/show_bug.cgi?id=171766

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b2c2ba40e73
Disable vibration APIs r=webidl,smaug

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3b2c2ba40e73

Comment 6

[Hamish Willee]

FF129 MDN docs work for this tracked in https://github.com/mdn/content/issues/34703 (essentially a compatibility data update and a release note).