Closed Bug 1900145 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 46573 - Remove redundant anchor reference from css-anchor-position WPT tests

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
128 Branch
Tracking Flags:
Tracking Status
firefox128 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 46573 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46573
Details from upstream follow.

Xianzhu Wang <wangxianzhu@chromium.org> wrote:

Remove redundant anchor reference from css-anchor-position WPT tests

Remove anchor references in anchor() if the reference is the same as
position-anchor.

For tests with anchor references from anchor() and anchor-size()
without position-anchor, modify a few of them by adding
position-anchor and remove anchor references, to increase test
coverage of anchor-size() implicitly use the default anchor, while
most of such tests are kept unchanged.

This will give web developers good examples of best usages. Previously
some web developers asked whether the redundant anchor references were
required.

Change-Id: I9bbdaa375afd845765266c272ca27cb565833257
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5588972
Reviewed-by: Mason Freed \<masonf@chromium.org>
Commit-Queue: Xianzhu Wang \<wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1308918}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 55 tests

Status Summary

Firefox

OK : 19
PASS: 7
FAIL: 86

Chrome

OK : 19
PASS: 93

Safari

OK : 19
PASS: 7
FAIL: 86

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d28481a9e6e3 [wpt PR 46573] - Remove redundant anchor reference from css-anchor-position WPT tests, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d28481a9e6e3

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox128: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch
You need to log in before you can comment on or make changes to this bug.