1900232 - Implement parsing of CSS 'anchor-size()' function in the sizing properties

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Jonathan Watt [:jwatt]]

https://drafts.csswg.org/css-anchor-position-1/#anchor-size-fn

('top', 'left', 'bottom', 'right', 'inset-block-start', 'inset-block-end', 'inset-inline-start', 'inset-inline-end', 'inset-block', 'inset-inline', and 'inset')

Comment 1

[David Shin[:dshin]]

Attachment: Bug 1900232: Part 1 - Add `GenericAnchorSize()` for `anchor-size()`. r=#style

Comment 2

[David Shin[:dshin]]

Attachment: Bug 1900232: Part 2 - Create one place to shim inset getters. r=#style

... Instead of handling anchor() function at each site manually.

Depends on D222530

Comment 3

[David Shin[:dshin]]

Attachment: Bug 1900232: Part 3 - Add `anchor-size()` to inset properties. r=#style

Depends on D222531

Comment 4

[David Shin[:dshin]]

Attachment: Bug 1900232: Part 4 - Add `anchor-size()` to margin properties. r=#style

Depends on D222532

Comment 5

[David Shin[:dshin]]

Attachment: Bug 1900232: Part 5 - Add `anchor-size()` to sizing properties. r=#style

Depends on D222533

Comment 6

[David Shin[:dshin]]

Attachment: Bug 1900232: Part 6 - Adjust test expectations for `anchor-size`. r=#style

1. WPT tests now accept anchor-size() property for sizing, inset, and
   margin properties [1].
2. Adjust test expectations for anchor-size() fallbacks containing
   anchor-size() - This will need to be followed up once [2] is resolved.
3. Adjust expectations for devtools' auto-completion related mochitests.

[1] https://github.com/w3c/csswg-drafts/issues/9827
[2] https://github.com/w3c/csswg-drafts/issues/10831

Still Failing WPT tests

Depends on D222534

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f61878e99adb
Part 1 - Add `GenericAnchorSize()` for `anchor-size()`. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/8b5b3715c147
Part 2 - Create one place to shim inset getters. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/b570acf3a29f
Part 3 - Add `anchor-size()` to inset properties. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/d0e997cc4143
Part 4 - Add `anchor-size()` to margin properties. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/ba6ed0972153
Part 5 - Add `anchor-size()` to sizing properties. r=firefox-style-system-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/a0bc0fe119dd
Part 6 - Adjust test expectations for `anchor-size`. r=firefox-style-system-reviewers,devtools-reviewers,nchevobbe,emilio

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/48307 for changes under testing/web-platform/tests

Comment 9

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/f61878e99adb
https://hg.mozilla.org/mozilla-central/rev/8b5b3715c147
https://hg.mozilla.org/mozilla-central/rev/b570acf3a29f
https://hg.mozilla.org/mozilla-central/rev/d0e997cc4143
https://hg.mozilla.org/mozilla-central/rev/ba6ed0972153
https://hg.mozilla.org/mozilla-central/rev/a0bc0fe119dd

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 11

[Mayank Bansal]

This increased the number of static constructors by 1 .. but not sure if that metric is currently being tracked.

Comment 12

[David Shin[:dshin]]

Hm - TIL that metric exists.

I did add 3 static consts, but they're simple enough that it shouldn't significantly add to static init duration?