1900331 - Missing photos icon in the Downloads panel when saving screenshots with long titles

Status: NEW

(Firefox :: Screenshots, defect, P3)

Description

[Simona Badau, Desktop QA]

Attachment: Screen recording with the issue

Found in

• Nightly 128.0a1

Affected versions

• Nightly 128.0a1

Tested platforms

• Affected platforms: Windows 10
• Unaffected platforms: macOS 13

Steps to reproduce

1. Navigate to this website with the long title:
   https://www.amazon.com/Purifiers-MOOKA-Purifier-Fragrance-Wildfire/dp/B0CP7QSRHV/ref=sr_1_3?_encoding=UTF8&content-id=amzn1.sym.68f2b66e-afdb-4a19-b88c-555da04d6dc2&crid=1QBODY970JKYC&dib=eyJ2IjoiMSJ9._3GXzCEJnUwCqhbUuXiWXv1MWMELlrXzAC5jhuBRUB5qVjcC7NG_dM2Nk1TMyq3mR_Mix8yk-JJx7CrnwQtDR-ZASsakeKKKdj0mWFsO0MQgksY4WGrt8lkzLaDaA96oO6JDK083pSM7MdR0wFErDxSnO_NHqaR2gg2ZrbF3IWi0goE76Tsjn2SxecXiTmllvRdQbysYh0OpDUsSCIYFayOaWdBpQMqgEFxrqUrT-tAsqbJ1whXrwuEclLo-kQuXo-J53wecpAFT79AvkduzPhh58bhIPhK6LT9jdG8MCiY.fFgPjuT3HoVrwYYiTcZKT27yL8eqgl3-1Xgb4MxokKI&dib_tag=se&keywords=Home&pd_rd_r=9b7fa24f-44c7-4414-957a-e517dfccae49&pd_rd_w=SSLkA&pd_rd_wg=Krswt&pf_rd_p=68f2b66e-afdb-4a19-b88c-555da04d6dc2&pf_rd_r=B3667J9M8PCBS6V3CQJ0&qid=1716235458&s=kitchen-intl-ship&sprefix=home%2Ckitchen-intl-ship%2C164&sr=1-3
2. Enable Screenshots.
3. Click on 'Save full page' and then on 'Download'.
4. Observe the saved screenshot in the Downloads panel.

Expected result

• In the Downloads panel, the newly saved screenshot should display the photos file icon to the left of its name.

Actual result

• The screenshot does not have the specific file icon displayed in the downloads panel.

Regression range
Found commit message:
Bug 1898027 - Update max filename length for screenshots downloads.r=sfoster,kcochrane

Additional notes

• I am not reproducing this when downloading screenshots from pages that have a shorter titles.
• Here is another example of a page where I see the missing file icon.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:niklas, since you are the author of the regressor, bug 1898027, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Daniel Holbert [:dholbert]]

Hmm, the screen recording isn't playing for me (in Firefox, Chrome, Safari, & VLC video player). Maybe it's corrupted somehow -- could you try re-recording/reposting?

I also just tried to repro in Win11 (which I've got locally, though I see you were using Win10) and I'm not seeing any issue with the icon so far.

Comment 3

[Simona Badau, Desktop QA]

Attachment: 2024-06-03_13h00_07.mp4

Re-attached the screen recording that shows the first saved screenshot (with the long title) with the missing icon and the second saved screenshot (that has a shorter title) with the default photo icon.

Comment 4

[:Gijs (he/him)]

So for me on macOS, this kind of has a worse problem which is that the screenshot fails to save at all, with:

DOMException: Could not remove 'path/to/Downloads/Screenshot 2024-06-07 at 13-36-01 Amazon.com Air Purifiers for Home Large Room Pets Up to 1300 Sq Ft MOOKA H13 True HEPA Air Purifier Cleaner with 360° Air Inlet Fragrance 13dB Air Purifier for Bedroom Wildfire Smoke Pet Dust Pollen Odor Home & Kitchen.png' (NS_ERROR_FILE_NAME_TOO_LONG)
Failed to create download using filename: path/to/Downloads/Screenshot 2024-06-07 at 13-36-06 Amazon.com Air Purifiers for Home Large Room Pets Up to 1300 Sq Ft MOOKA H13 True HEPA Air Purifier Cleaner with 360° Air Inlet Fragrance 13dB Air Purifier for Bedroom Wildfire Smoke Pet Dust Pollen Odor Home & Kitchen.png (length: 286)

This seems like an issue with screenshots, as it does not prompt for a filename. It should probably have some checks (maybe via the existing sanitize filename support?) on the automatically generated filename.

Comment 5

[Marco Bonardo [:mak]]

I can reproduce this bug on Windows 11 if browser.download.useDownloadDir is set to true. If I set it to false, then it works.

Comment 6

[:Gijs (he/him)]

(In reply to :Gijs (he/him) from comment #4)

So for me on macOS, this kind of has a worse problem which is that the screenshot fails to save at all, with:

DOMException: Could not remove 'path/to/Downloads/Screenshot 2024-06-07 at 13-36-01 Amazon.com Air Purifiers for Home Large Room Pets Up to 1300 Sq Ft MOOKA H13 True HEPA Air Purifier Cleaner with 360° Air Inlet Fragrance 13dB Air Purifier for Bedroom Wildfire Smoke Pet Dust Pollen Odor Home & Kitchen.png' (NS_ERROR_FILE_NAME_TOO_LONG)
Failed to create download using filename: path/to/Downloads/Screenshot 2024-06-07 at 13-36-06 Amazon.com Air Purifiers for Home Large Room Pets Up to 1300 Sq Ft MOOKA H13 True HEPA Air Purifier Cleaner with 360° Air Inlet Fragrance 13dB Air Purifier for Bedroom Wildfire Smoke Pet Dust Pollen Odor Home & Kitchen.png (length: 286)

This seems like an issue with screenshots, as it does not prompt for a filename. It should probably have some checks (maybe via the existing sanitize filename support?) on the automatically generated filename.

Ah, and it looks like this was fixed in bug 1898027.

Still, this feels like something where we need some screenshots investigation...