1900427 - Expose CookieJarSettings on nsIGlobalObject for current anti-tracking partitioning idiom in relation to StorageAccess checks

Status: ASSIGNED

(Core :: DOM: Core & HTML, enhancement)

Description

[Andrew Sutherland [:asuth] (he/him)]

Currently we have an idiom in storage access checks like in ServiceWorkerContainer where we do a StorageAccess check and then need to pass CookieJarSettings to mozilla::StoragePartitioningEnabled to be able to determine what to do with that value:

auto storageAllowed = StorageAllowedForWindow(window);
if (NS_WARN_IF(storageAllowed != StorageAccess::eAllow &&
               (!StaticPrefs::privacy_partition_serviceWorkers() ||
                !StoragePartitioningEnabled(storageAllowed,
                                            doc->CookieJarSettings())))) {

While the proposed StorageKey abstraction in bug 1776271 should help us clean up the idiom, in the meantime it's desirable to expose the value on nsIGlobalObject so that we can use the same logic path for windows and workers via nsIGlobalObject like for bug 1131324 that will expose ServiceWorkerContainer on workers. This should help simplify any future cleanups like bug 1776271.

While the change is small, I think it's probably likely useful for this change to have its own bug number and place for discussion. I do currently plan to land this as part of a larger stack, however.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Attachment: Bug 1900427 - Expose CookieJarSettings on nsIGlobalObject. r=smaug!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:asuth, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.