Closed Bug 1900454 Opened 4 months ago Closed 1 month ago

"File Regression Bug for" doesn't work for "mozpreftest" test framework

Categories

(Tree Management :: Perfherder, defect, P1)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cpeterson, Assigned: myeongjun.ko)

References

Details

(Whiteboard: [fxp])

Steps to reproduce

  1. Search for an untriaged Perfherder alert for a "mozperftest" test regression: https://treeherder.mozilla.org/perfherder/alerts?hideDwnToInv=1&page=1&framework=15&status=-1
  2. If there is no untriaged alert for a "mozperftest" regression, you can temporarily unlink a triaged alert from its Bugzilla bug so Perfherder will show the "File bug" menu item. If you don't this, don't forget to remember the bug number you unlinked and to restore the alert's link to that bug!!
  3. Open the alert's "investigating" and click the "File bug" menu item.
  4. In the "File Regression Bug for" dialog, click the "File Bug" button.

Expected behavior

Perfherder should open Bugzilla new bug form.

Actual behavior

Nothing happens. In the web console, I see the following JavaScript error:

Uncaught (in promise) TypeError: can't access property "text", i is undefined
    fileBug StatusDropdown.jsx:123
    fileBugAndClose StatusDropdown.jsx:214
    updateAndClose StatusDropdown.jsx:303
    handleSubmit FileBugModal.jsx:56
    onClick FileBugModal.jsx:106
    onClick Button.js:52
    React 11
    unstable_runWithPriority scheduler.production.min.js:18
    React 14
    unstable_runWithPriority scheduler.production.min.js:18
    React 5
StatusDropdown.jsx:123:34
    handleSubmit FileBugModal.jsx:56
    AsyncFunctionThrow self-hosted:808
    (Async: async)
    onClick FileBugModal.jsx:106
    onClick Button.js:52
    React 11
    unstable_runWithPriority scheduler.production.min.js:18
    React 6
    forEach self-hosted:4285
    React 8
    unstable_runWithPriority scheduler.production.min.js:18
    React 5

Dave Hunt suggests this is because Perfherder doesn't have a bug template for the "mozperftest" framework:

https://github.com/mozilla/treeherder/blob/aa367c6905699b38b49cce6c55682eefd85f498b/treeherder/perf/fixtures/performance_bug_templates.yaml

Whiteboard: [fxp]

This should be resolved now thanks to Jun's patch here: https://github.com/mozilla/treeherder/commit/c52e086e3de8e3ce7d9c8f0612dcb2ea26e64c86

Assignee: nobody → myeongjun.ko
Severity: -- → S3
Status: NEW → RESOLVED
Closed: 1 month ago
Priority: -- → P1
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.