1900458 - Ship @starting-style

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, task, P3)

Description

[Boris Chiou [:boris]]

Enable layout.css.starting-style-at-rules.enabled on all channels after Fx129 if everything looks good.

Comment 1

[Tom S [:evilpie]]

Do you mean to ship with version 129 or 130?

Comment 2

[Boris Chiou [:boris]]

Yes. I will send an intend-to-ship mail first and enable the preference.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 1900458 - Ship @starting-style rule.

Per https://groups.google.com/a/mozilla.org/g/dev-platform/c/bxSic3XP7oM,
we would like to ship @starting-style rule.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58c2beb544be
Ship @starting-style rule. r=layout-reviewers,webidl,saschanaz,emilio

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/58c2beb544be

Comment 6

[Donal Meehan [:dmeehan]]

:boris could you consider nominating this for a release note? (Process info)
We could include it in the nightly release notes.

Comment 7

[Boris Chiou [:boris]]

Release Note Request (optional, but appreciated)
[Why is this notable]: We ship a new feature, transition-behavior CSS property. This property allows us to create a transition on discrete animated CSS properties.
[Affects Firefox for Android]: Yes
[Suggested wording]: Ship transition-behavior property, which specifies whether transitions will be started or not for discrete properties.
[Links (documentation, blog post, etc)]: https://drafts.csswg.org/css-transitions-2/#transition-behavior-property

Comment 8

[Donal Meehan [:dmeehan]]

:boris, looks like your comment 7 should have been added to Bug 1901645. Also, a comment in Bug 1901645 should have been the release note content for this. Pasting here to make clear it up.

Release Note Request (optional, but appreciated)
[Why is this notable]: We ship a new feature, @starting-style rule. This rule allows us to define the starting style which could be used as the before-change style to start the CSS transitions on the first rendering.
[Affects Firefox for Android]: Yes
[Suggested wording]: Ship @starting-style rule. The style rules inside it are used to establish styles to transition from, if the previous style change event did not establish a before-change style for the element whose styles are being computed.
[Links (documentation, blog post, etc)]: https://drafts.csswg.org/css-transitions-2/#at-ruledef-starting-style

Comment 9

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx129 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx129 release notes

Comment 10

[Dave Letorey]

When this is released, will it also support animating from display: none; this appears to be working in nightly (129.0a1)?
Actually I am wrong here it is not working in nightly.

Comment 11

[Boris Chiou [:boris]]

(In reply to Dave Letorey from comment #10)

When this is released, will it also support animating from display: none; this appears to be working in nightly (129.0a1)?
Actually I am wrong here it is not working in nightly.

The animation of display property depends on Bug 1834877. We don't support the animation of display property now.

However, if you just change the display property value from none, we will create the transitions on other properties, per the starting style (e.g. the wpt)

Comment 12

[Dave Letorey]

Related Pull Requests

• Firefox Release note PR
• BCD PR