[wpt-sync] Sync PR 46603 - Make ::details-content be display:block when the <details> is open.
Categories
(Core :: DOM: Core & HTML, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox128 | --- | fixed |
People
(Reporter: wpt-sync, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 46603 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/46603
Details from upstream follow.
L. David Baron <dbaron@chromium.org> wrote:
Make ::details-content be display:block when the <details> is open.
This (conditional on DetailsStyling being enabled) makes
::details-content be display:block all the time rather than only when
the \<details> is closed.This makes the pseudo-element substantially easier to use since many
styles do not work on display: contents, and having to use display:block
in order to use those styles leads to confusion.Bug: 1469418
Change-Id: I504bfd1343a5c4109d3233a06c3b6818f8c16ca9
Reviewed-on: https://chromium-review.googlesource.com/5594192
WPT-Export-Revision: 1ac363315fd6e749516c0e1810c3f2ac9f133e1e
| Assignee | ||
Updated•1 year ago
|
| Assignee | ||
Comment 1•1 year ago
|
||
| Assignee | ||
Comment 2•1 year ago
|
||
CI Results
Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI
Total 7 tests and 1 subtests
Status Summary
Firefox
OK : 1
PASS: 2[GitHub] 4[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt]
FAIL: 3[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 5[GitHub]
Chrome
OK : 1
PASS: 5
FAIL: 2
Safari
OK : 1
PASS: 1
FAIL: 6
Links
Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base
Details
New Tests That Don't Pass
- /html/rendering/the-details-element/details-display-type-001.tentative.html [wpt.fyi]:
FAIL[GitHub],PASS[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:PASS, Safari:FAIL) - /html/rendering/the-details-element/details-display-type-002.tentative.html [wpt.fyi]:
FAIL[GitHub],PASS[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview,Gecko-android-em-7.0-x86_64-qr-debug-geckoview,Gecko-android-em-7.0-x86_64-qr-opt-geckoview,Gecko-linux1804-64-qr-debug,Gecko-linux1804-64-qr-opt,Gecko-windows11-32-2009-qr-debug,Gecko-windows11-32-2009-qr-opt,Gecko-windows11-64-2009-qr-debug,Gecko-windows11-64-2009-qr-opt] (Chrome:PASS, Safari:FAIL) - /html/rendering/the-details-element/details-pseudo-elements-001.tentative.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:FAIL) - /html/rendering/the-details-element/details-pseudo-elements-002.tentative.html [wpt.fyi]:
FAIL(Chrome:PASS, Safari:FAIL) - /html/rendering/the-details-element/details-pseudo-elements-003.tentative.html [wpt.fyi]:
FAIL(Chrome:FAIL, Safari:FAIL)
Comment 4•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9a6fa480c997
https://hg.mozilla.org/mozilla-central/rev/75a780059e30
Description
•