1900498 - Color choices missing from Reader Mode

Status: RESOLVED INVALID

(Toolkit :: Reader Mode, defect)

Description

[08xjcec48]

Steps to reproduce:

• Go to about:reader?url=https://en.wikipedia.org/wiki/Firefox on Firefox 126.0.1

• Click on Aa and see all the color options

• Enable improved_text_menu.enabled in Firefox Nightly

• Go to about:reader?url=https://en.wikipedia.org/wiki/Firefox

• Click on Aa

Actual results:

The old menu offered different color themes: Auto, Light, Dark, Sepia.

The new menu has no color options.

Expected results:

Please don't remove this customization option. Users choose different colors depending on the time of the day and the text they're reading.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Old type controls menu

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hi 08xjcec48,

I'm confused. The old "Aa" (Text controls) menu never had color-related options. It only had options for text spacing (see screenshot) and font serifs. If you click on the paint brush icon (Theme), the colour controls should be visible there... is that what you're looking for?

Comment 3

[08xjcec48]

Attachment: old.png

Comment 4

[08xjcec48]

Attachment: new.png

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Ah - I realize now that the themes button is only available to me because reader.colors_menu.enabled is set to true.

Hey cmkm, is the plan to enable reader.colors_menu.enabled and improved_text_menu.enabled at the same time?

Comment 6

[08xjcec48]

Not even the person who made this blog post knew about this other preference: https://blog.nightly.mozilla.org/2024/05/09/screenshots-these-weeks-in-firefox-issue-160/ :)

Comment 7

[Cieara Meador [:cmkm]]

That's correct, both of the prefs need to be toggled and they'll both be switched at rollout.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Okay, great! Thanks. In that case, I think we can INVALID this - the new panel won't be enabled without the theme panel as well, which is where colour selection will be.