1900522 - Minor cleanup in size computation functions

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

These patches are discovered while reading our size computation APIs. See the patches for details.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1900522 Part 1 - Use IsIntrinsicKeyword() to implement HasIntrinsicKeywordForBSize(). r?#layout

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1900522 Part 2 - Swap the arguments of StyleRect::Get() that gets T from logical side. r?#layout

This patch move WritingMode to the second argument, for the consistency with
the design of its own APIs like StyleRect::Start(LogicalAxis, WritingMode),
and logical classes such as LogicalMargin::Side(LogicalSide, WritingMode).

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1900522 Part 3 - Update autogen_warning in servo/ports/geckolib/cbindgen.toml. r?#layout

We don't need to manually generate ServoStyleConsts.h. Update the warning to
avoid confusion.

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1900522 Part 4 - Remove nsLayoutUtils::ComputeBSizeDependentValue(). r?#layout

ComputeBSizeDependentValue() is the same as ComputeCBDependentValue() except
for the assertion, and existing callers of it are passing containing block's
block-size, which indicates that calling ComputeCBDependentValue() might make
more sense.

Comment 5

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1900522 Part 5 - Simplify some ComputeCBDependentValue() usages. r?#layout

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1900522 Part 6 - Remove a SizeComputationInput::ComputeISizeValue() variant. r?#layout

This removed one is just forwarding the call to nsIFrame, and used internally
within ReflowInput.

While I'm here, rename local variables inside* and outside* to make them
clearer.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/062103f7392c
Part 1 - Use IsIntrinsicKeyword() to implement HasIntrinsicKeywordForBSize(). r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/2e310084e774
Part 2 - Swap the arguments of StyleRect::Get() that gets T from logical side. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/0827429f288b
Part 3 - Update autogen_warning in servo/ports/geckolib/cbindgen.toml. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/253f4ea10489
Part 4 - Remove nsLayoutUtils::ComputeBSizeDependentValue(). r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/065a346ac916
Part 5 - Simplify some ComputeCBDependentValue() usages. r=layout-reviewers,emilio
https://hg.mozilla.org/integration/autoland/rev/dfaa55b2c652
Part 6 - Remove a SizeComputationInput::ComputeISizeValue() variant. r=layout-reviewers,emilio

Comment 8

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/062103f7392c
https://hg.mozilla.org/mozilla-central/rev/2e310084e774
https://hg.mozilla.org/mozilla-central/rev/0827429f288b
https://hg.mozilla.org/mozilla-central/rev/253f4ea10489
https://hg.mozilla.org/mozilla-central/rev/065a346ac916
https://hg.mozilla.org/mozilla-central/rev/dfaa55b2c652