1900537 - [meta] Messaging Layer Security - Implement a prototype Web API

Status: RESOLVED FIXED

(Core :: DOM: Security, task)

Description

[Benjamin Beurdouche [:beurdouche]]

This task aims to provide an implementation of the prototype Web API

Comment 1

[Benjamin Beurdouche [:beurdouche]]

Attachment: Bug 1900537 - Part 3: Web API for MLS. r=nika,emilio

Depends on D203682

Comment 2

[Benjamin Beurdouche [:beurdouche]]

Attachment: WIP: Bug 1900537 - Part 4: Extend ClearDataService to handle MLS state. r=emilio

Comment 3

[Benjamin Beurdouche [:beurdouche]]

Attachment: Bug 1900537 - Part 4: Extend ClearDataService to handle MLS state. r=emilio,emz

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1306fe3ef6d3
Part 3: Web API for MLS. r=webidl,ipc-reviewers,smaug,nika
https://hg.mozilla.org/integration/autoland/rev/7b1ab2c1bfb6
Part 4: Extend ClearDataService to handle MLS state. r=emilio,pbz

Comment 5

[agoloman]

Backed out for causing for causing multiple failures.

• Backout link

Bc failures @browser_fingerprinting_randomization_key.js.

• Push with failures
• Failure Log
  ————————————————————————————————————
  Bc failures @browser_394759_purge.js.
• Push with failures
• Failure Log
  ————————————————————————————————————

xpcshell failures @test_clear_forgetAboutSite.js.

• Push with failures
• Failure Log
  ————————————————————————————————————

Mochitest failures @est_webauthn_attestation_conveyance.html.

• Push with failures
• Failure Log

Comment 6

[Benjamin Beurdouche [:beurdouche]]

The webauthn failure seems unrelated at first glance because we are not touching that code. I am investigating the other failures.

Comment 7

[Benjamin Beurdouche [:beurdouche]]

I can't figure out if those are intermittent or not, they look like it, any ideas ?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

They seem legit? You're changing clearsitedata and they are complaining about stuff throwing.

Comment 9

[Emma Zühlcke [:emz]]

Check if your cleaner is throwing / returning a non success code in any of the test scenarios related to the failing test.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9db0177b920
Part 3: Web API for MLS. r=webidl,ipc-reviewers,smaug,nika
https://hg.mozilla.org/integration/autoland/rev/7085f64159d1
Part 4: Extend ClearDataService to handle MLS state. r=emilio,emz

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54ff63eb9703
Part 3: Web API for MLS. r=webidl,ipc-reviewers,smaug,nika
https://hg.mozilla.org/integration/autoland/rev/3d59c5411aa5
Part 4: Extend ClearDataService to handle MLS state. r=emilio,emz

Comment 12

[Sandor Molnar[:smolnar]]

Backed out for causing linux build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/afa1013c2e3013ee65a6f03fe76ca7a75b5051c5

Push with failures

Failure log -> ERROR - error: failed to parse lock file at: /builds/worker/checkouts/gecko/Cargo.lock

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/519f2beaa972
Part 3: Web API for MLS. r=webidl,ipc-reviewers,smaug,nika
https://hg.mozilla.org/integration/autoland/rev/560116c848c7
Part 4: Extend ClearDataService to handle MLS state. r=emilio,emz

Comment 14

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/15f7ac573c9aaf0de5f7427508f78c66fceab530

Push with failures

Failure log ->

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0780cbb52eeb
Part 3: Web API for MLS. r=webidl,ipc-reviewers,smaug,nika
https://hg.mozilla.org/integration/autoland/rev/2e1c3fe92eea
Part 4: Extend ClearDataService to handle MLS state. r=emilio,emz

Comment 16

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/0780cbb52eeb
https://hg.mozilla.org/mozilla-central/rev/2e1c3fe92eea

Comment 17

[Andra Esanu (needinfo me)]

(In reply to Sandor Molnar[:smolnar] from comment #14)

Backed out for causing build bustages

Backout link: https://hg.mozilla.org/integration/autoland/rev/15f7ac573c9aaf0de5f7427508f78c66fceab530

Push with failures

Failure log ->

Perfherder has detected a browsertime performance change from push 15f7ac573c9aaf0de5f7427508f78c66fceab530.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
10%	instagram fcp	linux1804-64-shippable-qr	bytecode-cached cold fission webrender	274.95 -> 302.14	Before/After
6%	instagram largestContentfulPaint	linux1804-64-shippable-qr	bytecode-cached cold fission webrender	1,787.78 -> 1,897.53	Before/After
5%	instagram PerceptualSpeedIndex	linux1804-64-shippable-qr	cold fission webrender	1,045.52 -> 1,095.69	Before/After
4%	instagram LastVisualChange	linux1804-64-shippable-qr	cold fission webrender	1,918.53 -> 1,993.58	Before/After
4%	instagram PerceptualSpeedIndex	linux1804-64-shippable-qr	bytecode-cached cold fission webrender	1,051.69 -> 1,091.71	Before/After
4%	instagram largestContentfulPaint	linux1804-64-shippable-qr	bytecode-cached cold fission webrender	1,832.77 -> 1,896.88	Before/After
3%	instagram SpeedIndex	linux1804-64-shippable-qr	cold fission webrender	1,543.72 -> 1,596.28	Before/After
3%	instagram largestContentfulPaint	linux1804-64-shippable-qr	cold fission webrender	1,822.62 -> 1,883.26	Before/After
3%	instagram LastVisualChange	linux1804-64-shippable-qr	bytecode-cached cold fission webrender	1,967.06 -> 2,026.26	Before/After
3%	instagram SpeedIndex	linux1804-64-shippable-qr	bytecode-cached cold fission webrender	1,547.73 -> 1,592.34	Before/After

As author of one of the patches included in that push, we need your help to address this regression.
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 43215

For more information on performance sheriffing please see our FAQ.

Comment 18

[Benjamin Beurdouche [:beurdouche]]

No action needed.

The code related to the current bug has no ability to affect these metrics. Also, the perfherder metrics show flat in december after the alert while this code is in MC, so it looks like a bad correlation from the tooling.