1900565 - The storage access check won't handle properly if the channel isn't associated with a browsing context

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P2)

Description

[Tim Huang[:timhuang]]

In some cases, the channel won't have a target browsing context, such as the channel for loading a script for remote workers. The storage access check cannot correctly handle this case, so there will be no partitioning for such channels.

Comment 1

[Tim Huang[:timhuang]]

Attachment: Bug 1900565 - Don't immediately return from the ShouldAllowAccessFor(nsIChannel) if the channel doesn't have target browsing context. r?bvandersloot!

The patch modifies the ShouldAllowAccessFor(nsIChannel) to handle the
channels that don't have target browsing context. For example, the
channel for loading shared worker scripts won't have a associated
browsing context. In this case, the ShouldAllowAccessFor() should still
work but just ignore the checks that require the browsing context.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0760609c946
Don't immediately return from the ShouldAllowAccessFor(nsIChannel) if the channel doesn't have target browsing context. r=bvandersloot

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f0760609c946