Closed
Bug 1900592
Opened 22 days ago
Closed 13 days ago
Implement keyframe request in VideoEncoder
Categories
(Core :: Audio/Video: Web Codecs, defect)
Core
Audio/Video: Web Codecs
Tracking
()
RESOLVED
FIXED
129 Branch
Tracking | Status | |
---|---|---|
firefox129 | --- | fixed |
People
(Reporter: padenot, Assigned: padenot, NeedInfo)
References
(Blocks 1 open bug, Regressed 2 open bugs)
Details
Attachments
(6 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
No description provided.
Assignee | ||
Comment 1•22 days ago
|
||
Updated•22 days ago
|
Assignee: nobody → padenot
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•20 days ago
|
||
Assignee | ||
Comment 3•20 days ago
|
||
If input frames have times like this:
pts=1 duration=33333
pts=2 duration=33333
pts=3 duration=33333
then the MFT changes the pts to be the previous pts + the previous frame
duration. Web Codecs requires the pts to be untouched.
Assignee | ||
Comment 4•20 days ago
|
||
Somehow this fails for me, only for vp9.
Assignee | ||
Comment 5•20 days ago
|
||
Assignee | ||
Comment 6•20 days ago
|
||
It's already implemented on macOS PEM.
Assignee | ||
Comment 7•16 days ago
|
||
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/41ebd7b701f3 Allow requesting a keyframe in WMF PEM. r=chunmin https://hg.mozilla.org/integration/autoland/rev/5b55062d570a Don't always trust sample time when decoding using WMF. r=alwu https://hg.mozilla.org/integration/autoland/rev/7bd06d186511 Use the new pts queue to side-step an error when attempting to get the pts of a sample that had a negative pts set. r=alwu https://hg.mozilla.org/integration/autoland/rev/d830fabe313b Print the duration in WMF encoder and decoder log. r=chunmin https://hg.mozilla.org/integration/autoland/rev/a2bf43c4c87c Only override MFT pts when using the decoder through Web Codecs. r=alwu
Comment 9•13 days ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/41ebd7b701f3
https://hg.mozilla.org/mozilla-central/rev/5b55062d570a
https://hg.mozilla.org/mozilla-central/rev/7bd06d186511
https://hg.mozilla.org/mozilla-central/rev/d830fabe313b
https://hg.mozilla.org/mozilla-central/rev/a2bf43c4c87c
Status: ASSIGNED → RESOLVED
Closed: 13 days ago
status-firefox129:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
Comment 10•9 days ago
|
||
Pushed by padenot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/15e2f4d0e6c0 Teach FFmpegVideoEncoder to force a key frame. r=chunmin
Comment 11•9 days ago
|
||
Backout by sstanca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5dabfab7d5a5 Backed out changeset 15e2f4d0e6c0 for causing codecs failures. CLOSED TREE
Comment 12•9 days ago
|
||
Backed out for causing codecs failures.
- Backout link
- Push with failures
- Failure Log
- Failure line: PROCESS-CRASH | application crashed [@ mv_cost] | /webcodecs/full-cycle-test.https.any.html?av1
Flags: needinfo?(padenot)
You need to log in
before you can comment on or make changes to this bug.
Description
•