1900592 - Implement keyframe request in VideoEncoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Web Codecs, defect)

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 1900592 - Teach FFmpegVideoEncoder to force a key frame. r?chunmin

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1900592 - Allow requesting a keyframe in WMF PEM. r?chunmin

Comment 3

[Paul Adenot (:padenot)]

Attachment: Bug 1900592 - Don't always trust sample time when decoding using WMF. r?alwu

If input frames have times like this:

pts=1 duration=33333
pts=2 duration=33333
pts=3 duration=33333

then the MFT changes the pts to be the previous pts + the previous frame
duration. Web Codecs requires the pts to be untouched.

Comment 4

[Paul Adenot (:padenot)]

Attachment: Bug 1900592 - Use the new pts queue to side-step an error when attempting to get the pts of a sample that had a negative pts set. r?alwu

Somehow this fails for me, only for vp9.

Comment 5

[Paul Adenot (:padenot)]

Attachment: Bug 1900592 - Print the duration in WMF encoder and decoder log. r?chunmin

Comment 6

[Paul Adenot (:padenot)]

It's already implemented on macOS PEM.

Comment 7

[Paul Adenot (:padenot)]

Attachment: Bug 1900592 - Only override MFT pts when using the decoder through Web Codecs. r?alwu

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41ebd7b701f3
Allow requesting a keyframe in WMF PEM. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/5b55062d570a
Don't always trust sample time when decoding using WMF. r=alwu
https://hg.mozilla.org/integration/autoland/rev/7bd06d186511
Use the new pts queue to side-step an error when attempting to get the pts of a sample that had a negative pts set. r=alwu
https://hg.mozilla.org/integration/autoland/rev/d830fabe313b
Print the duration in WMF encoder and decoder log. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a2bf43c4c87c
Only override MFT pts when using the decoder through Web Codecs. r=alwu

Comment 9

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/41ebd7b701f3
https://hg.mozilla.org/mozilla-central/rev/5b55062d570a
https://hg.mozilla.org/mozilla-central/rev/7bd06d186511
https://hg.mozilla.org/mozilla-central/rev/d830fabe313b
https://hg.mozilla.org/mozilla-central/rev/a2bf43c4c87c

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15e2f4d0e6c0
Teach FFmpegVideoEncoder to force a key frame. r=chunmin

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dabfab7d5a5
Backed out changeset 15e2f4d0e6c0 for causing codecs failures. CLOSED TREE

Comment 12

[Serban Stanca [:SerbanS]]

Backed out for causing codecs failures.

• Backout link
• Push with failures
• Failure Log
• Failure line: PROCESS-CRASH | application crashed [@ mv_cost] | /webcodecs/full-cycle-test.https.any.html?av1

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7abfd54b842
Teach FFmpegVideoEncoder to force a key frame. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/fccce5c14020
1902627, 1903055, 1903071, 1903582: apply code formatting via Lando

Comment 14

[Norisz Fay [:noriszfay]]

Backed out alongside Bug 1903071, Bug 1902627, Bug 1903055, Bug 1903582 for causing build bustages on FFmpegDataEncoder.cpp

Backout link

Push with failures

Failure log

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c5a8aec3bbe
Teach FFmpegVideoEncoder to force a key frame. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/11a817706ebb
1902627, 1903055, 1903071, 1903582: apply code formatting via Lando

Comment 16

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/2c5a8aec3bbe
https://hg.mozilla.org/mozilla-central/rev/11a817706ebb