Closed Bug 1900592 Opened 2 months ago Closed 1 month ago

Implement keyframe request in VideoEncoder

Categories

(Core :: Audio/Video: Web Codecs, defect)

defect

Tracking

()

RESOLVED FIXED
129 Branch
Tracking Status
firefox129 --- fixed

People

(Reporter: padenot, Assigned: padenot)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

Attachments

(6 files)

No description provided.
Assignee: nobody → padenot
Status: NEW → ASSIGNED

If input frames have times like this:

pts=1 duration=33333
pts=2 duration=33333
pts=3 duration=33333

then the MFT changes the pts to be the previous pts + the previous frame
duration. Web Codecs requires the pts to be untouched.

It's already implemented on macOS PEM.

Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41ebd7b701f3
Allow requesting a keyframe in WMF PEM. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/5b55062d570a
Don't always trust sample time when decoding using WMF. r=alwu
https://hg.mozilla.org/integration/autoland/rev/7bd06d186511
Use the new pts queue to side-step an error when attempting to get the pts of a sample that had a negative pts set. r=alwu
https://hg.mozilla.org/integration/autoland/rev/d830fabe313b
Print the duration in WMF encoder and decoder log. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/a2bf43c4c87c
Only override MFT pts when using the decoder through Web Codecs. r=alwu
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/15e2f4d0e6c0
Teach FFmpegVideoEncoder to force a key frame. r=chunmin
Backout by sstanca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5dabfab7d5a5
Backed out changeset 15e2f4d0e6c0 for causing codecs failures. CLOSED TREE

Backed out for causing codecs failures.

Flags: needinfo?(padenot)
Regressions: 1903669
Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a7abfd54b842
Teach FFmpegVideoEncoder to force a key frame. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/fccce5c14020
1902627, 1903055, 1903071, 1903582: apply code formatting via Lando

Backed out alongside Bug 1903071, Bug 1902627, Bug 1903055, Bug 1903582 for causing build bustages on FFmpegDataEncoder.cpp

Backout link

Push with failures

Failure log

Pushed by padenot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c5a8aec3bbe
Teach FFmpegVideoEncoder to force a key frame. r=chunmin
https://hg.mozilla.org/integration/autoland/rev/11a817706ebb
1902627, 1903055, 1903071, 1903582: apply code formatting via Lando
Regressions: 1905661
Flags: needinfo?(padenot)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: